From 42ca5870543d3dfa0c7a20b36cc1f716f0c16f9a Mon Sep 17 00:00:00 2001 From: Daniel Mil <84205762+mildaniel@users.noreply.github.com> Date: Tue, 20 Feb 2024 16:35:40 -0800 Subject: [PATCH] fix(test): Skip SIGTERM tests on Windows (#6722) * fix(test): Skip SIGTERM tests on Windows * Format files --- tests/integration/local/start_api/test_start_api.py | 3 +++ tests/integration/local/start_lambda/test_start_lambda.py | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tests/integration/local/start_api/test_start_api.py b/tests/integration/local/start_api/test_start_api.py index 2cd0ae888a..8381087313 100644 --- a/tests/integration/local/start_api/test_start_api.py +++ b/tests/integration/local/start_api/test_start_api.py @@ -1,6 +1,7 @@ import base64 import shutil import signal +from unittest import skipIf import uuid import random from pathlib import Path @@ -17,6 +18,7 @@ from samcli.commands.local.cli_common.invoke_context import ContainersInitializationMode from samcli.local.apigw.route import Route +from tests.testing_utils import IS_WINDOWS from .start_api_integ_base import StartApiIntegBaseClass, WritableStartApiIntegBaseClass from ..invoke.layer_utils import LayerUtils @@ -2161,6 +2163,7 @@ def test_can_invoke_lambda_function_successfully(self): self.assertEqual(response.json(), {"hello": "world"}) +@skipIf(IS_WINDOWS, "SIGTERM interrupt doesn't exist on Windows") class TestWarmContainersHandlesSigTerm(TestWarmContainersBaseClass): template_path = "/testdata/start_api/template-warm-containers.yaml" container_mode = ContainersInitializationMode.EAGER.value diff --git a/tests/integration/local/start_lambda/test_start_lambda.py b/tests/integration/local/start_lambda/test_start_lambda.py index 3599029018..fcf740a4d5 100644 --- a/tests/integration/local/start_lambda/test_start_lambda.py +++ b/tests/integration/local/start_lambda/test_start_lambda.py @@ -1,4 +1,5 @@ import signal +from unittest import skipIf import uuid from concurrent.futures import ThreadPoolExecutor, as_completed from time import time, sleep @@ -14,6 +15,7 @@ from botocore.exceptions import ClientError from samcli.commands.local.cli_common.invoke_context import ContainersInitializationMode +from tests.testing_utils import IS_WINDOWS from .start_lambda_api_integ_base import StartLambdaIntegBaseClass, WatchWarmContainersIntegBaseClass @@ -340,6 +342,7 @@ def test_can_invoke_lambda_function_successfully(self): self.assertEqual(json.loads(response.get("body")), {"hello": "world"}) +@skipIf(IS_WINDOWS, "SIGTERM interrupt doesn't exist on Windows") class TestWarmContainersHandlesSigTermInterrupt(TestWarmContainersBaseClass): template_path = "/testdata/start_api/template-warm-containers.yaml" container_mode = ContainersInitializationMode.EAGER.value