fix(deps): revert to typescript-eslint v6.21.0 #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert the @typescript-eslint package to version 6.21.0. This is for the sake of building with older versions of Node.js.
marofke
approved these changes
Jul 24, 2024
loachri
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Attempting to build the RFDK with an older version of Node.js fails with an error:
Solution
Revert the
@typescript-eslintpackage to version 6.21.0. This is newer than the version 6.14.0 that we used in our most recent release, but lower than version 7.0 which dropped support for older versions of Node.js.Testing
Confirmed that
yarn run buildworks with Node.js 18.17.1.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license