You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When generating a MonorepoTsProject, the generated ESLint configuration seems set up to include the projenrc configuration files... But the structure of the eslint task only runs lint in the monorepo packages so does not capture the monorepo-level projen code.
Expected Behavior
Default ESLint configuration for a MonorepoTsProject should also lint .projenrc.ts and projenrc/**.ts files
Current Behavior
I see the created root eslintrc.json seems to explicitly provision for linting the projenrc config files:
This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.
Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen. If you wish to exclude this issue from being marked as stale, add the "backlog" label.
Describe the bug
When generating a
MonorepoTsProject
, the generated ESLint configuration seems set up to include the projenrc configuration files... But the structure of theeslint
task only runs lint in the monorepo packages so does not capture the monorepo-level projen code.Expected Behavior
Default ESLint configuration for a
MonorepoTsProject
should also lint.projenrc.ts
andprojenrc/**.ts
filesCurrent Behavior
I see the created root
eslintrc.json
seems to explicitly provision for linting the projenrc config files:...But the generated
tasks.json
task just runs eslint in sub-packages via nx - which won't capture the top-level linting:Reproduction Steps
npx projen new --from @aws/pdk monorepo-ts
.projenrc.ts
file with some whitespace error that prettier/eslint should catchnpm run eslint
: The projenrc file will not be re-formatted.Possible Solution
Maybe MonorepoTsProject should add an additional step to the
eslint
task to run at the root/monorepo level?I'm tentatively working around it for now with:
Additional Information/Context
No response
PDK version used
0.23.44
What languages are you seeing this issue on?
Typescript
Environment details (OS name and version, etc.)
macOS, projen v0.82.8
The text was updated successfully, but these errors were encountered: