Skip to content

Commit

Permalink
fix socat integration CI (#1833)
Browse files Browse the repository at this point in the history
socat started cutting off the tests prematurely if the test hadn't
finished yet with these commits:
* 4d03b37da1226f5d76d1503487d7cd8b90c4d80
* b5b9ee0031eb0f38a71b44a45723d728265ee1bd

A lot of tests are related to specific warnings that socat emits based
on the openssl version not supporting certain things. My suspicion is
that the additional time when writing to the logs breaks the 3
millisecond threshold and socat determines that we've failed the test.
Extending this time threshold to 50 milliseconds gets past things.
  
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
  • Loading branch information
samuel40791765 authored Sep 6, 2024
1 parent 16ca6e7 commit c36c0e9
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions tests/ci/integration/run_socat_integration.sh
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ function build_and_test_socat() {
autoconf
./configure --enable-openssl-base="$AWS_LC_INSTALL_FOLDER"
make -j "$NUM_CPU_THREADS"
# See: t/V1497389456.
# socat decreased the test wait time to 3 milliseconds, which causes failures when additional warnings/logs are written.
# Extending the wait time to 50 milliseconds is just right for us.
sed -i 's/MILLIs=\$((3/MILLIs=\$((50/' ./test.sh
# test 146 OPENSSLLISTENDSA: fails because AWS-LC doesn't support FFDH ciphersuites which are needed for DSA
# test 216 UDP6MULTICAST_UNIDIR: known flaky test in socat with newer kernels
# test 309 OPENSSLRENEG1: AWS-LC doesn't support renegotiation by default, it can be enabled by calling SSL_set_renegotiate_mode
Expand Down

0 comments on commit c36c0e9

Please sign in to comment.