How should I test the change I add in JsonExceptionWriterHelpers?

[Anirudhrawat]

Hello everyone, I am new to open source but not to development. I am working on JsonExceptionWriterHelper.cs class. I think it is quite easy to understand and fix. I am simply looking for TODO in the code. The TODO I am working on is this one:

/// This method escapes a string for use as a JSON string value.
/// It was adapted from the PutString method in the LitJson.JsonWriter class.
/// TODO: rewrite the *JsonExceptionWriter classes to use a JSON library instead of building strings directly.

Please tell me am I doing it a right way?

Lastly, how I need to text the change I add? I see a test folder and see multiple tests, do I need to create my own test for the change I implement?

[ashishdhingra]

@Anirudhrawat Please confirm if your question is related to usage of aws-lambda-dotnet library? If it's a plain JSON helper test question, there are other open source forums to better address this question.

[Anirudhrawat]

@ashishdhingra Yes it related to aws-lambda-dotnet. The class is present in the repository. Here is the link: link

[ashishdhingra]

@Anirudhrawat I see that you have submitted PR #1584. The PR is assigned to @normj for review. The helper method is trying to escape strings properly in JSON format. May be you could write a unit test case that compares actual and expected output (per old logic) for different string escape sequences, when used with new logic!

[github-actions[bot]]

Hello! Reopening this discussion to make it searchable.