Fix segmentation fault in iot client init functions (#430)

* Fix segmentation fault in iot client init functions
* Added slight delay to Jobs sample so the output is always printed to the terminal, even on fast machines

Author: TwistedTwigleg

identity/source/IotIdentityClient.cpp

@@ -26,7 +26,7 @@ namespace Aws
         {
         }
 
-        IotIdentityClient::operator bool() const noexcept { return *m_connection; }
+        IotIdentityClient::operator bool() const noexcept { return m_connection && *m_connection; }
 
         int IotIdentityClient::GetLastError() const noexcept { return aws_last_error(); }
 

jobs/source/IotJobsClient.cpp

@@ -33,7 +33,7 @@ namespace Aws
         {
         }
 
-        IotJobsClient::operator bool() const noexcept { return *m_connection; }
+        IotJobsClient::operator bool() const noexcept { return m_connection && *m_connection; }
 
         int IotJobsClient::GetLastError() const noexcept { return aws_last_error(); }
 

samples/jobs/describe_job_execution/main.cpp

@@ -15,6 +15,7 @@
 #include <aws/iotjobs/RejectedError.h>
 
 #include <algorithm>
+#include <chrono>
 #include <condition_variable>
 #include <iostream>
 #include <mutex>
@@ -168,6 +169,9 @@ int main(int argc, char *argv[])
         publishDescribeJobExeCompletedPromise.get_future().wait();
     }
 
+    /* Wait just a little bit to let the console print */
+    std::this_thread::sleep_for(std::chrono::milliseconds(500));
+
     /* Disconnect */
     if (connection->Disconnect())
     {

secure_tunneling/source/IotSecureTunnelingClient.cpp

@@ -29,7 +29,7 @@ namespace Aws
         {
         }
 
-        IotSecureTunnelingClient::operator bool() const noexcept { return *m_connection; }
+        IotSecureTunnelingClient::operator bool() const noexcept { return m_connection && *m_connection; }
 
         int IotSecureTunnelingClient::GetLastError() const noexcept { return aws_last_error(); }
 

shadow/source/IotShadowClient.cpp

@@ -38,7 +38,7 @@ namespace Aws
         {
         }
 
-        IotShadowClient::operator bool() const noexcept { return *m_connection; }
+        IotShadowClient::operator bool() const noexcept { return m_connection && *m_connection; }
 
         int IotShadowClient::GetLastError() const noexcept { return aws_last_error(); }