-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare_new_cl.sh generates broken scripts and templates. #559
Comments
Hello, Thanks for reporting this issue, we're taking a look at it Thanks! |
Dear customer, Thanks for reporting the issue. The prepare_new_cl.sh script is intended to only set up the directory structure thats similar to our cl_examples for customers to add their designs. The cl_template.sv itself is not a standalone design and is just intended as a place holder for customer design. We recommend to run one of our examples like cl_hello_world or cl_dram_dma for a quick start and add the design to cl_template when want to create custom_design and update the build scripts with corresponding source files. Please feel free to let us know if you have any follow up questions. Thanks |
The minimum expectation from a template is that it should be clean start point for a new design. The current script is obliviously not a clean start-point. I ended up using a cleaned up template and folder layout from another site for my design. In case Amazon AWS does not have the resources to fix this issue will they accept a PR? |
Dear customer, Thanks for using the F1 developer kit and providing your valuable feedback to AWS. We are continuously improving our developer kit and we currently have cl_examples that are recommended as a starting point to explore F1. In addition, we will be happy to review PR for the cl_template. Please feel free to provide any additional feedback that you have. Thanks |
The script prepare_new_cl.sh in aws-fpga/hdk/cl/developer_designs/ generates broken code and scripts.
Issues noticed so far:
design/cl_template.sv
While scripts inbuild/scripts
referencescl_hello_world
everywhere.design/cl_id_defines.vh
andcommon/design/cl_common_defines.vh
design/cl_template.sv
throws 40+ errors during compilation. e.g.The text was updated successfully, but these errors were encountered: