Skip to content

Encrypt/Decrypt API #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seebees opened this issue Apr 28, 2020 · 1 comment
Closed

Encrypt/Decrypt API #289

seebees opened this issue Apr 28, 2020 · 1 comment
Assignees
@robin-aws
Labels
specification

Comments

@seebees
Copy link
Contributor

seebees commented Apr 28, 2020 •
edited by robin-aws
Loading

This group deals with the high level encrypt/decrypt APIs.
The keyring trace is the highlight here as it has some interesting possibilities for complex error "handling" and debugging.

See 97

Keyring Trace

  1. [feature proposal] additional keyring trace entries awslabs/aws-encryption-sdk-specification#97
  2. define how keyring trace manifests in the ESDK client interface and how users should interact with it awslabs/aws-encryption-sdk-specification#95
  3. Clarify if keyring trace entries are a hard requirement on Materials structures awslabs/aws-encryption-sdk-specification#70
  4. OnEncrypt and OnDecrypt in KMS Keyring contains wrong key id for the keyring trace awslabs/aws-encryption-sdk-specification#60

decrypt API

  1. review decrypt API output - add at least encryption context awslabs/aws-encryption-sdk-specification#96
  2. decrypt client API does not state that the keyring trace is needed on output awslabs/aws-encryption-sdk-specification#78
  3. Remove message header as part of the decrypt API output awslabs/aws-encryption-sdk-specification#25

Error Handling (in trace?)

  1. KMSKeyring error handling awslabs/aws-encryption-sdk-specification#40
@acioc acioc added this to the .NET PenTest milestone Apr 28, 2020
@robin-aws robin-aws self-assigned this Apr 30, 2020
@mattsb42-aws mattsb42-aws mentioned this issue Apr 30, 2020
Closed
@robin-aws
Copy link
Contributor

Edit: Moved awslabs/aws-encryption-sdk-specification#55 to #290 since it shouldn't be related to the keyring trace - the error should happen when initializing/constructing the KMS keyring.

@MatthewBennington MatthewBennington mentioned this issue May 4, 2020
Merged
ShubhamChaturvedi7 pushed a commit that referenced this issue Mar 13, 2025
@josecorella
test(dafny): write manifests with only mkp and in legacy format (#289)
3c64a1b 
Updates include:
- New CLI option to only generate manifests that are compatible with
MasterKeyProviders and with libraries that have non-dafny keyrings
- Tests reads/writes with the ESDK for JavaScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robin-aws robin-aws

Labels
specification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@seebees @acioc @robin-aws @farleyb-amazon