chore: pin linter dependencies and enable dependabot (#192)

Author: josecorella

.github/dependabot.yml

@@ -0,0 +1,13 @@
+version: 2
+updates:
+  # master
+  - package-ecosystem: "pip"
+    directory: "/dev_requirements"
+    schedule:
+      interval: "daily"
+
+  # Github Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"

.github/workflows/ci_static-analysis.yaml

@@ -37,7 +37,7 @@ jobs:
           python-version: 3.8
       - run: |
           python -m pip install --upgrade pip
-          pip install --upgrade -r ci-requirements.txt
+          pip install --upgrade -r dev_requirements/ci-requirements.txt
       - name: check
         env:
           TOXENV: ${{ matrix.category }}

.github/workflows/ci_tests.yaml

@@ -44,7 +44,7 @@ jobs:
           architecture: ${{ matrix.platform.architecture }}
       - run: |
           python -m pip install --upgrade pip
-          pip install --upgrade -r ci-requirements.txt
+          pip install --upgrade -r dev_requirements/ci-requirements.txt
       - name: run test
         env:
           TOXENV: ${{ matrix.category }}
@@ -65,7 +65,7 @@ jobs:
           python-version: 3.7
       - run: |
           python -m pip install --upgrade pip
-          pip install --upgrade -r ci-requirements.txt
+          pip install --upgrade -r dev_requirements/ci-requirements.txt
       - name: run test
         env:
           TOXENV: ${{ matrix.category }}

.readthedocs.yaml

@@ -17,6 +17,6 @@ submodules:
 python:
   version: 3.8
   install:
-    - requirements: doc/requirements.txt
+    - requirements: dev_requirements/doc-requirements.txt
     - method: setuptools
       path: .

ci-requirements.txt

@@ -0,0 +1 @@
+tox==3.24.5

dev_requirements/ci-requirements.txt

@@ -1,2 +1,2 @@
-sphinx==4.2.0
+sphinx==4.4.0
 sphinx_rtd_theme==1.0.0

doc/requirements.txt renamed to dev_requirements/doc-requirements.txt

@@ -0,0 +1,16 @@
+bandit==1.7.2
+black==22.1.0
+doc8==0.10.1
+flake8==4.0.1
+flake8-docstrings==1.6.0
+flake8-isort==4.1.1
+# https://github.com/JBKahn/flake8-print/pull/30
+flake8-print==4.0.0
+isort==5.10.1
+pylint==2.12.2
+pyflakes==2.4.0
+# https://github.com/PyCQA/pydocstyle/issues/375
+pydocstyle==3.0.0
+readme_renderer==32.0
+seed-isort-config==2.2.0
+vulture==2.3

dev_requirements/linter-requirements.txt

@@ -0,0 +1,4 @@
+pypi-parker==0.1.2
+setuptools==60.7.1
+twine==3.8.0
+wheel==0.37.1

dev_requirements/release-requirements.txt

@@ -0,0 +1,9 @@
+hypothesis==5.49.0
+mock==4.0.3
+moto==3.0.2
+pytest==7.0.0
+pytest-cov==3.0.0
+pytest-mock==3.6.1
+pytest-xdist==2.5.0
+boto3==1.20.51
+botocore==1.23.51

dev_requirements/test-requirements.txt

@@ -6,5 +6,5 @@ if [ -z ${1} ]; then
 fi
 
 pip install -r requirements.txt
-pip install -r test/requirements.txt
+pip install -r dev_requirements/test-requirements.txt
 pip freeze > ${1}

test/freeze-upstream-requirements.sh

@@ -26,7 +26,7 @@ EXTRACTEDDIR=$(ls | tail -1)
 cd ${EXTRACTEDDIR}
 
 echo "Installing requirements from extracted source build."
-pip install -r test/requirements.txt
+pip install -r dev_requirements/test-requirements.txt
 pip install -e .
 
 echo "Running tests from extracted source build."

test/requirements.txt

@@ -60,7 +60,7 @@ passenv =
     # Pass through the default AWS region (used for integration tests)
     AWS_DEFAULT_REGION
 sitepackages = False
-deps = -rtest/requirements.txt
+deps = -rdev_requirements/test-requirements.txt
 # 'download' forces tox to always upgrade pip to the latest
 download = true
 commands =
@@ -91,7 +91,7 @@ commands =
     # Do not select any specific markers
     manual: {[testenv:base-command]commands}
     # Only run examples tests
-    examples: {[testenv:base-command]commands} examples/test/ -m "examples"
+    examples: {[testenv:base-command]commands} examples/test -m "examples"
 
 # Run code coverage on the unit tests
 [testenv:coverage]
@@ -106,7 +106,7 @@ sitepackages = False
 passenv =
 setenv =
 #########################################################
-deps = -rtest/requirements.txt
+deps = -rdev_requirements/test-requirements.txt
 commands = {[testenv:base-command]commands} -m "local and not slow and not veryslow and not nope" --ignore=examples
 
 # Collect requirements for use in upstream tests
@@ -149,6 +149,7 @@ sitepackages = False
 recreate = True
 deps =
     {[testenv:build]deps}
+    -rdev_requirements/test-requirements.txt
 commands =
     {[testenv:build]commands}
     {toxinidir}/test/source-build-check.sh {envtmpdir} {toxinidir}/dist
@@ -186,14 +187,7 @@ commands =
 # Linters
 [testenv:flake8]
 basepython = python3
-deps =
-    flake8
-    flake8-docstrings
-    flake8-isort
-    # https://github.com/PyCQA/pydocstyle/issues/375
-    pydocstyle<4.0.0
-    # https://github.com/JBKahn/flake8-print/pull/30
-    flake8-print>=3.1.0
+deps = -rdev_requirements/linter-requirements.txt
 commands =
     flake8 \
         src/dynamodb_encryption_sdk/ \
@@ -202,7 +196,7 @@ commands =
 
 [testenv:flake8-tests]
 basepython = {[testenv:flake8]basepython}
-deps = {[testenv:flake8]deps}
+deps = -rdev_requirements/linter-requirements.txt
 commands =
     flake8 \
         # Ignore F811 redefinition errors in tests (breaks with pytest-mock use)
@@ -214,7 +208,7 @@ commands =
 
 [testenv:flake8-examples]
 basepython = {[testenv:flake8]basepython}
-deps = {[testenv:flake8]deps}
+deps = {[testenv:flake8]deps} 
 commands =
     flake8 \
         # Ignore C901 complexity requirements (examples optimize for straightforward readability)
@@ -232,8 +226,7 @@ commands =
 basepython = python3
 deps =
     {[testenv]deps}
-    pyflakes
-    pylint
+    -rdev_requirements/linter-requirements.txt
 commands =
     pylint \
         --rcfile=src/pylintrc \
@@ -261,8 +254,7 @@ commands =
 
 [testenv:blacken-src]
 basepython = python3
-deps =
-    black
+deps = -rdev_requirements/linter-requirements.txt
 commands =
     black --line-length 120 \
         src/dynamodb_encryption_sdk/ \
@@ -276,28 +268,24 @@ commands =
 
 [testenv:blacken]
 basepython = python3
-deps =
-    {[testenv:blacken-src]deps}
+deps = {[testenv:blacken-src]deps}
 commands =
     {[testenv:blacken-src]commands}
 
 [testenv:black-check]
 basepython = python3
-deps =
-    {[testenv:blacken]deps}
+deps = {[testenv:blacken]deps}
 commands =
     {[testenv:blacken-src]commands} --diff
 
 [testenv:isort-seed]
 basepython = python3
-deps = seed-isort-config
+deps = -rdev_requirements/linter-requirements.txt
 commands = seed-isort-config
 
 [testenv:isort]
 basepython = python3
-# We need >=5.0.0 because
-# several configuration settings changed with 5.0.0
-deps = isort>=5.0.0
+deps = -rdev_requirements/linter-requirements.txt
 commands = isort \
     src \
     test \
@@ -316,8 +304,8 @@ commands = {[testenv:isort]commands} -c
 [testenv:autoformat]
 basepython = python3
 deps =
-    {[testenv:isort]deps}
     {[testenv:blacken]deps}
+    {[testenv:isort]deps}
 commands =
     {[testenv:isort]commands}
     {[testenv:blacken]commands}
@@ -337,27 +325,27 @@ commands =
 basepython = python3
 whitelist_externals = {[testenv:resetdocs]whitelist_externals}
 deps =
-    sphinx
-    doc8
+    -rdev_requirements/doc-requirements.txt
+    -rdev_requirements/linter-requirements.txt
 commands = 
     {[testenv:resetdocs]commands}
     doc8 doc/index.rst doc/lib/ README.rst CHANGELOG.rst
 
 
 [testenv:readme]
 basepython = python3
-deps = readme_renderer
+deps = -rdev_requirements/linter-requirements.txt
 commands = python setup.py check -r -s
 
 [testenv:bandit]
 basepython = python3
-deps = bandit
+deps = -rdev_requirements/linter-requirements.txt
 commands = bandit -r src/dynamodb_encryption_sdk/
 
 # Prone to false positives: only run independently
 [testenv:vulture]
 basepython = python3
-deps = vulture
+deps = -rdev_requirements/linter-requirements.txt
 commands = vulture src/dynamodb_encryption_sdk/
 
 [testenv:linters]
@@ -387,7 +375,7 @@ commands =
 # Documentation
 [testenv:docs]
 basepython = python3
-deps = -rdoc/requirements.txt
+deps = -rdev_requirements/doc-requirements.txt
 commands =
     sphinx-build -E -c doc/ -b html doc/ doc/build/html
     sphinx-build -E -c doc/ -b linkcheck doc/ doc/build/html
@@ -404,27 +392,21 @@ commands =
 [testenv:park]
 basepython = python3
 skip_install = true
-deps =
-    pypi-parker
-    setuptools
+deps = -rdev_requirements/release-requirements.txt
 commands = python setup.py park
 
 # Release tooling
 [testenv:build]
 basepython = python3
 skip_install = true
-deps =
-    wheel
-    setuptools
+deps = -rdev_requirements/release-requirements.txt
 commands =
     python setup.py sdist bdist_wheel
 
 [testenv:release-base]
 basepython = python3
 skip_install = true
-deps =
-    {[testenv:build]deps}
-    twine
+deps = -rdev_requirements/release-requirements.txt
 passenv =
     # Intentionally omit TWINE_REPOSITORY_URL from the passenv list,
     # as this overrides other ways of setting the repository and could