chore: pin linter dependencies (#198)

Author: josecorella

.github/workflows/ci_tests.yaml

@@ -38,7 +38,7 @@ jobs:
     #          - examples
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-python@v1
+      - uses: actions/setup-python@v2
         with:
           python-version: 2.7
           architecture: ${{ matrix.platform.architecture }}
@@ -79,7 +79,7 @@ jobs:
 #          - examples
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-python@v1
+      - uses: actions/setup-python@v2
         with:
           python-version: ${{ matrix.python }}
           architecture: ${{ matrix.platform.architecture }}

codebuild/python2.7.yml

@@ -14,5 +14,7 @@ phases:
         python: latest
   build:
     commands:
-      - pip install tox
+      - pyenv install 2.7.17
+      - pyenv local 2.7.17
+      - pip install tox tox-pyenv
       - tox

codebuild/python3.6.yml

@@ -14,5 +14,7 @@ phases:
         python: latest
   build:
     commands:
-      - pip install tox
+      - pyenv install 3.6.15
+      - pyenv local 3.6.15
+      - pip install tox tox-pyenv
       - tox

codebuild/python3.8.yml

@@ -14,5 +14,7 @@ phases:
         python: latest
   build:
     commands:
-      - pip install tox
+      - pyenv install 3.8.12
+      - pyenv local 3.8.12
+      - pip install tox tox-pyenv
       - tox

dev_requirements/linter-requirements.txt

@@ -0,0 +1,16 @@
+bandit==1.7.0
+black==21.12b0
+doc8==0.10.1
+flake8==4.0.1
+flake8-bugbear==21.11.29
+flake8-docstrings==1.6.0
+flake8-isort==4.1.1
+flake8-print==4.0.0
+isort==5.10.1
+pydocstyle==3.0.0
+pyflakes==2.4.0
+pylint==2.12.2
+readme_renderer==32.0
+seed-isort-config==2.2.0
+vulture==2.3
+sphinx==4.4.0

doc/conf.py

@@ -29,7 +29,7 @@ def get_version():
     return _release
 
 
-project = u"dynamodb-encryption-sdk-python"
+project = u"dynamodb-encryption-sdk-python"  # pylint: disable=redundant-u-string-prefix
 version = get_version()
 release = get_release()
 
@@ -53,7 +53,7 @@ def get_version():
 source_suffix = ".rst"  # The suffix of source filenames.
 master_doc = "index"  # The master toctree document.
 
-copyright = u"%s, Amazon" % datetime.now().year  # pylint: disable=redefined-builtin
+copyright = u"%s, Amazon" % datetime.now().year  # pylint: disable=redefined-builtin,redundant-u-string-prefix
 
 # List of directories, relative to source directory, that shouldn't be searched
 # for source files.

examples/test/pylintrc

@@ -10,6 +10,7 @@ disable =
                    # pylint does not recognize this
     duplicate-code,  # tests for similar things tend to be similar
     redefined-outer-name,  # raises false positives with fixtures
+    consider-using-f-string,
 
 [DESIGN]
 max-args = 10

src/pylintrc

@@ -8,6 +8,7 @@ disable =
     useless-object-inheritance,
     raise-missing-from,
     super-with-arguments,
+    consider-using-f-string
 
 [BASIC]
 # Allow function names up to 50 characters

test/pylintrc

@@ -10,10 +10,13 @@ disable =
     protected-access,  # raised when calling _ methods
     redefined-outer-name,  # raised when using pytest-mock
     unused-argument,  # raised when patches and fixtures are needed but not called
+    unspecified-encoding,
     # All below are disabled because we need to support Python 2
     useless-object-inheritance,
     raise-missing-from,
     super-with-arguments,
+    consider-using-f-string,
+    redundant-u-string-prefix,
 
 [DESIGN]
 max-args = 10

test/requirements.txt

@@ -1,7 +1,10 @@
 hypothesis>=5.0.0,<6.0.0;python_version>='3'
 hypothesis==4.57.1;python_version=='2.7'
 mock
-moto>=1.3.8
+moto>=1.3.8;python_version>='3'
+# must be less than 2.2.x as Moto removed support for python2 as of moto 2.2.x.
+# https://github.com/spulec/moto/issues/3612
+moto>=1.3.8,<2.2.0;python_version=='2.7'
 pytest>=3.4.0
 pytest-cov
 pytest-mock

test/unit/material_providers/test_aws_kms.py

@@ -225,7 +225,7 @@ def test_loaded_key_infos():
     [
         pytest.param(val, id=str(val))
         for val in all_possible_combinations_kwargs(
-            dict(),
+            {},
             dict(botocore_session=botocore.session.Session()),
             dict(grant_tokens=("sdvoaweih", "auwshefiouawh")),
             dict(material_description={"asoiufeoia": "soajfijewi"}),

tox.ini

@@ -216,13 +216,7 @@ commands =
 [testenv:flake8]
 basepython = python3
 deps =
-    flake8
-    flake8-docstrings
-    flake8-isort
-    # https://github.com/PyCQA/pydocstyle/issues/375
-    pydocstyle<4.0.0
-    # https://github.com/JBKahn/flake8-print/pull/30
-    flake8-print>=3.1.0
+    -rdev_requirements/linter-requirements.txt
 commands =
     flake8 \
         src/dynamodb_encryption_sdk/ \
@@ -238,7 +232,7 @@ commands =
         # Ignore D101-107 docstring requirements for tests
         # E203 is not PEP8 compliant https://github.com/ambv/black#slices
         # W503 is not PEP8 compliant https://github.com/ambv/black#line-breaks--binary-operators
-        --ignore F811,D101,D102,D103,D107,E203,W503 \
+        --ignore F811,D101,D102,D103,D107,E203,W503,B011 \
         test/
 
 [testenv:flake8-examples]
@@ -261,8 +255,7 @@ commands =
 basepython = python3
 deps =
     {[testenv]deps}
-    pyflakes
-    pylint
+    -rdev_requirements/linter-requirements.txt
 commands =
     pylint \
         --rcfile=src/pylintrc \
@@ -291,7 +284,7 @@ commands =
 [testenv:blacken-src]
 basepython = python3
 deps =
-    black
+    -rdev_requirements/linter-requirements.txt
 commands =
     black --line-length 120 \
         src/dynamodb_encryption_sdk/ \
@@ -324,9 +317,8 @@ commands = seed-isort-config
 
 [testenv:isort]
 basepython = python3
-# We need >=5.0.0 because
-# several configuration settings changed with 5.0.0
-deps = isort>=5.0.0
+deps =
+    -rdev_requirements/linter-requirements.txt
 commands = isort \
     src \
     test \
@@ -366,27 +358,28 @@ commands =
 basepython = python3
 whitelist_externals = {[testenv:resetdocs]whitelist_externals}
 deps =
-    sphinx
-    doc8
-commands = 
+    -rdev_requirements/linter-requirements.txt
+commands =
     {[testenv:resetdocs]commands}
     doc8 doc/index.rst doc/lib/ README.rst CHANGELOG.rst
-    
 
 [testenv:readme]
 basepython = python3
-deps = readme_renderer
+deps =
+    -rdev_requirements/linter-requirements.txt
 commands = python setup.py check -r -s
 
 [testenv:bandit]
 basepython = python3
-deps = bandit
+deps =
+    -rdev_requirements/linter-requirements.txt
 commands = bandit -r src/dynamodb_encryption_sdk/
 
 # Prone to false positives: only run independently
 [testenv:vulture]
 basepython = python3
-deps = vulture
+deps =
+    -rdev_requirements/linter-requirements.txt
 commands = vulture src/dynamodb_encryption_sdk/
 
 [testenv:linters]