Skip to content

Commit 8be3fcb

Browse files
philasmarphilasmar
committed
make more settings visible
1 parent 7092453 commit 8be3fcb

7 files changed

+27
-1
lines changed

‎src/AWS.Deploy.CLI/ServerMode/Controllers/DeploymentController.cs

+8-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,12 @@ private List<OptionSettingItemSummary> ListOptionSettingSummary(IOptionSettingHa
200200

201201
foreach (var setting in configurableOptionSettings)
202202
{
203-
var settingSummary = new OptionSettingItemSummary(setting.Id, setting.FullyQualifiedId, setting.Name, setting.Description, setting.Type.ToString())
203+
var settingSummary = new OptionSettingItemSummary(
204+
setting.Id,
205+
setting.FullyQualifiedId,
206+
setting.Name,
207+
setting.Description,
208+
setting.Type.ToString())
204209
{
205210
Category = setting.Category,
206211
TypeHint = setting.TypeHint?.ToString(),
@@ -210,6 +215,8 @@ private List<OptionSettingItemSummary> ListOptionSettingSummary(IOptionSettingHa
210215
ReadOnly = recommendation.IsExistingCloudApplication && !setting.Updatable,
211216
Visible =
212217
optionSettingHandler.IsOptionSettingDisplayable(recommendation, setting) &&
218+
// Updating visibility of settings in server-mode to be determined by 'VisibleOnRedeployment'
219+
// when performing a redeployment and 'Updatable' is set to false.
213220
!(recommendation.IsExistingCloudApplication && !setting.Updatable && !setting.VisibleOnRedeployment),
214221
SummaryDisplayable = optionSettingHandler.IsSummaryDisplayable(recommendation, setting),
215222
AllowedValues = setting.AllowedValues,

‎src/AWS.Deploy.Recipes/RecipeDefinitions/ASP.NETAppAppRunner.recipe

+1
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@
289289
"Type": "String",
290290
"AdvancedSetting": true,
291291
"Updatable": false,
292+
"VisibleOnRedeployment": true,
292293
"Validators": [
293294
{
294295
"ValidatorType": "Regex",

‎src/AWS.Deploy.Recipes/RecipeDefinitions/ASP.NETAppECSFargate.recipe

+3
Original file line numberDiff line numberDiff line change
@@ -308,6 +308,7 @@
308308
"TypeHint": "Vpc",
309309
"AdvancedSetting": false,
310310
"Updatable": false,
311+
"VisibleOnRedeployment": true,
311312
"ChildOptionSettings": [
312313
{
313314
"Id": "IsDefault",
@@ -364,6 +365,7 @@
364365
"DefaultValue": "{DefaultVpcId}",
365366
"AdvancedSetting": false,
366367
"Updatable": false,
368+
"VisibleOnRedeployment": true,
367369
"Validators": [
368370
{
369371
"ValidatorType": "Regex",
@@ -537,6 +539,7 @@
537539
"DefaultValue": null,
538540
"AdvancedSetting": false,
539541
"Updatable": false,
542+
"VisibleOnRedeployment": true,
540543
"Validators": [
541544
{
542545
"ValidatorType": "Regex",

‎src/AWS.Deploy.Recipes/RecipeDefinitions/ASP.NETAppElasticBeanstalkLinux.recipe

+6
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@
347347
},
348348
"AdvancedSetting": false,
349349
"Updatable": false,
350+
"VisibleOnRedeployment": true,
350351
"ChildOptionSettings": [
351352
{
352353
"Id": "CreateNew",
@@ -368,6 +369,7 @@
368369
},
369370
"AdvancedSetting": false,
370371
"Updatable": false,
372+
"VisibleOnRedeployment": true,
371373
"DependsOn": [
372374
{
373375
"Id": "ApplicationIAMRole.CreateNew",
@@ -398,6 +400,7 @@
398400
},
399401
"AdvancedSetting": false,
400402
"Updatable": false,
403+
"VisibleOnRedeployment": true,
401404
"ChildOptionSettings": [
402405
{
403406
"Id": "CreateNew",
@@ -419,6 +422,7 @@
419422
},
420423
"AdvancedSetting": false,
421424
"Updatable": false,
425+
"VisibleOnRedeployment": true,
422426
"DependsOn": [
423427
{
424428
"Id": "ServiceIAMRole.CreateNew",
@@ -447,6 +451,7 @@
447451
"DefaultValue": "",
448452
"AdvancedSetting": true,
449453
"Updatable": false,
454+
"VisibleOnRedeployment": true,
450455
"Validators": [
451456
{
452457
"ValidatorType": "Regex",
@@ -826,6 +831,7 @@
826831
"DefaultValue": "{DefaultVpcId}",
827832
"AdvancedSetting": true,
828833
"Updatable": false,
834+
"VisibleOnRedeployment": true,
829835
"Validators": [
830836
{
831837
"ValidatorType": "Regex",

‎src/AWS.Deploy.Recipes/RecipeDefinitions/ASP.NETAppElasticBeanstalkWindows.recipe

+6
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,7 @@
335335
},
336336
"AdvancedSetting": false,
337337
"Updatable": false,
338+
"VisibleOnRedeployment": true,
338339
"ChildOptionSettings": [
339340
{
340341
"Id": "CreateNew",
@@ -356,6 +357,7 @@
356357
},
357358
"AdvancedSetting": false,
358359
"Updatable": false,
360+
"VisibleOnRedeployment": true,
359361
"DependsOn": [
360362
{
361363
"Id": "ApplicationIAMRole.CreateNew",
@@ -386,6 +388,7 @@
386388
},
387389
"AdvancedSetting": false,
388390
"Updatable": false,
391+
"VisibleOnRedeployment": true,
389392
"ChildOptionSettings": [
390393
{
391394
"Id": "CreateNew",
@@ -407,6 +410,7 @@
407410
},
408411
"AdvancedSetting": false,
409412
"Updatable": false,
413+
"VisibleOnRedeployment": true,
410414
"DependsOn": [
411415
{
412416
"Id": "ServiceIAMRole.CreateNew",
@@ -435,6 +439,7 @@
435439
"DefaultValue": "",
436440
"AdvancedSetting": true,
437441
"Updatable": false,
442+
"VisibleOnRedeployment": true,
438443
"Validators": [
439444
{
440445
"ValidatorType": "Regex",
@@ -820,6 +825,7 @@
820825
"DefaultValue": "{DefaultVpcId}",
821826
"AdvancedSetting": true,
822827
"Updatable": false,
828+
"VisibleOnRedeployment": true,
823829
"Validators": [
824830
{
825831
"ValidatorType": "Regex",

‎src/AWS.Deploy.Recipes/RecipeDefinitions/ConsoleAppECSFargateScheduleTask.recipe

+1
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@
326326
"DefaultValue": "{DefaultVpcId}",
327327
"AdvancedSetting": false,
328328
"Updatable": false,
329+
"VisibleOnRedeployment": true,
329330
"Validators": [
330331
{
331332
"ValidatorType": "Regex",

‎src/AWS.Deploy.Recipes/RecipeDefinitions/ConsoleAppECSFargateService.recipe

+2
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,7 @@
340340
"TypeHint": "Vpc",
341341
"AdvancedSetting": false,
342342
"Updatable": false,
343+
"VisibleOnRedeployment": true,
343344
"ChildOptionSettings": [
344345
{
345346
"Id": "IsDefault",
@@ -396,6 +397,7 @@
396397
"DefaultValue": "{DefaultVpcId}",
397398
"AdvancedSetting": false,
398399
"Updatable": false,
400+
"VisibleOnRedeployment": true,
399401
"Validators": [
400402
{
401403
"ValidatorType": "Regex",

0 commit comments

Comments
 (0)