Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(custom-resource-handler): hardcoded partition in s3 auto-delete-objects-handler #33212

Open
1 task
kaizencc opened this issue Jan 28, 2025 · 2 comments
Open
1 task
Assignees
Labels
@aws-cdk/aws-s3 Related to Amazon S3 @aws-cdk/custom-resources Related to AWS CDK Custom Resources bug This issue is a bug. p2

Comments

@kaizencc
Copy link
Contributor

kaizencc commented Jan 28, 2025

Describe the bug

When the linter was turned on in custom-resource-handlers, it alerted us to this line that was introduced here that fails the linter rule @cdklabs/no-literal-partition. This is our own custom linter rule that makes sure that we do not hardcode the aws partition anywhere because there are other partitions that need to be considered.

At best this is something that we need to scrutinize and document why we are allowing. At worst we need to fix this as a bug.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

no literal partitions

Current Behavior

literal partition

Reproduction Steps

see code

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

latest

Framework Version

No response

Node.js Version

latest

OS

mac

Language

TypeScript

Language Version

No response

Other information

No response

@kaizencc kaizencc added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 28, 2025
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Jan 28, 2025
@kaizencc kaizencc added @aws-cdk/custom-resources Related to AWS CDK Custom Resources and removed @aws-cdk/aws-s3 Related to Amazon S3 labels Jan 28, 2025
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Jan 28, 2025
@kaizencc
Copy link
Contributor Author

Linting happened here: #33204

@ashishdhingra ashishdhingra added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jan 28, 2025
@ashishdhingra
Copy link
Contributor

Issue opened by CDK team. Adding p2 as priority for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 @aws-cdk/custom-resources Related to AWS CDK Custom Resources bug This issue is a bug. p2
Projects
None yet
Development

No branches or pull requests

3 participants