From 6a0d9c3bbe09a5f1f090d861cd186a0eabad2c63 Mon Sep 17 00:00:00 2001 From: William Ashley Date: Mon, 8 Apr 2024 15:16:06 +0000 Subject: [PATCH 1/2] Make the -r argument to 'report' required and ensure the usage message indicates it accepts multiple values. Fixes #154. --- src/report.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/report.rs b/src/report.rs index 541c1127..318401c0 100644 --- a/src/report.rs +++ b/src/report.rs @@ -13,7 +13,7 @@ use std::path::{Path, PathBuf}; #[derive(Clone, Args, Debug)] pub struct Report { /// Run data to be visualized. Can be a directory or a tarball. - #[clap(short, long, value_parser)] + #[clap(short, long, value_parser, required = true, num_args = 1..)] run: Vec, /// Report name. From 8d9a3a3bbb81b26f74e252d89e3ecd48ce8e4ebf Mon Sep 17 00:00:00 2001 From: William Ashley Date: Tue, 9 Apr 2024 15:28:54 +0000 Subject: [PATCH 2/2] Address warning about unnecessary type cast --- src/data/processes.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/data/processes.rs b/src/data/processes.rs index e8dea6fd..70c2704b 100644 --- a/src/data/processes.rs +++ b/src/data/processes.rs @@ -243,7 +243,7 @@ impl GetData for Processes { Data::ProcessesRaw(ref value) => value, _ => panic!("Invalid Data type in raw file"), }; - *TICKS_PER_SECOND.lock().unwrap() = raw_value.ticks_per_second as u64; + *TICKS_PER_SECOND.lock().unwrap() = raw_value.ticks_per_second; let reader = BufReader::new(raw_value.data.as_bytes()); processes.time = raw_value.time; for line in reader.lines() {