init.image.pullPolicy and nodeAgent.image.pullPolicy not being respect

[zyue110026]

We have noticed two instances of incorrect helming in your Kubernetes configuration files. Hardcoded or default configuration values in the template are considered anti-pattern and configurable values in the values.yaml file are not being respect, resulting in user-provided configurations never being applied. Additionally, we provide anecdotal evidence from trivy-operator#729 regarding the incorrect helming defect.

What happened:

init.image.pullPolicy and nodeAgent.image.pullPolicy not take affect when changing them to other values. This is due to missing implementation for this value in daemonset.yaml file:

amazon-vpc-cni-k8s/charts/aws-vpc-cni/templates/daemonset.yaml

Line 41 in 2884e90

initContainers:

amazon-vpc-cni-k8s/charts/aws-vpc-cni/templates/daemonset.yaml

Line 128 in 2884e90

image: {{ include "aws-vpc-cni.nodeAgentImage" . }}

Attach logs

What you expected to happen:

change image pullpolicy for initcontainer and nodeAgent image can take affect, or delete these two values in value.yaml file

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version):
• CNI Version: main version
• OS (e.g: cat /etc/os-release):
• Kernel (e.g. uname -a):

[orsenthil]

This is fixed in #3010 and will be available in next release.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

[orsenthil]

This is fixed and released in VPC CNI 1.18.4+

[github-actions]

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.