Skip to content

Commit

Permalink
fix: ensure cleanup of service
Browse files Browse the repository at this point in the history
Previous fix in 26c7177 did not ensure cleanup of the service if the
TestServiceUp call failed. This would lead to situations in which
cluster deletion would fail in the TestCreateClusterWithFargateService
integration test because the cluster still contained an "active" service.
  • Loading branch information
SoManyHs committed Feb 28, 2020
1 parent 0dd2434 commit f7faf52
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions ecs-cli/integ/e2e/fargate_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,11 @@ func TestCreateClusterWithFargateService(t *testing.T) {
defer os.Remove(project.ComposeFileName)
defer os.Remove(project.ECSParamsFileName)

// Create a new service
cmd.TestServiceUp(t, project)

// Ensure cleanup of service
defer cmd.TestServiceDown(t, project)

// Create a new service
cmd.TestServiceUp(t, project)
cmd.TestServicePs(t, project, 1)

// Increase the number of running tasks
Expand Down

0 comments on commit f7faf52

Please sign in to comment.