feat: Add function to get job status #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis-Spidertracks
changed the title
chinglee-iot
requested review from
AniruddhaKanhere
and removed request for
AniruddhaKanhere
|
Thank you for creating this PR for job status APIs. We will look into this PR and discuss with you here. |
Comment on lines
+229
to
+238
| buildIndexedFileQueryString( fileIndex, | ||
| "fileType", | ||
| 8U, | ||
| queryString, | ||
| &queryStringLength ); | ||
| jsonResult = searchUintValue( jobDoc, | ||
| jobDocLength, | ||
| queryString, | ||
| queryStringLength, | ||
| &( result->fileType ) ); |
There was a problem hiding this comment.
I do not think that this is standard across all the job documents.
For example, here is a job doc from a job that I recently created:
{
"afr_ota": {
"protocols": [
"MQTT"
],
"streamname": "AFR_OTA-some-stream-name",
"files": [
{
"filepath": "NA",
"filesize": 624244,
"fileid": 0,
"certfile": "sss:00213243",
"update_data_url": null,
"auth_scheme": null,
"sig-sha256-ecdsa": "my-signature-goes-here"
}
]
}
}
| @@ -941,4 +987,4 @@ size_t Jobs_GetJobDocument( const char * message, | |||
| } | |||
|
|
|||
| return jobDocLength; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Can you add an empty line at the bottom of this file?
| @@ -1005,4 +1013,4 @@ bool Jobs_IsJobUpdateStatus( const char * topic, | |||
| #endif | |||
| /* *INDENT-ON* */ | |||
|
|
|||
| #endif /* ifndef JOBS_H_ */ | |||
| #endif /* ifndef JOBS_H_ */ | |||
|
@Travis-Spidertracks can you please respond to the above questions and comments? This PR is quite stale. If we do not hear back from you, I will close the PR. Thanks |
|
@Travis-Spidertracks, I am closing this PR due to lack of activity. Please feel free to reopen the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.