Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMR on EKS AddOn: failed to create the service-linked role due to the name conflict #865

Open
sambaiz opened this issue Oct 26, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@sambaiz
Copy link

sambaiz commented Oct 26, 2023

Describe the bug

EMR on EKS addons try creating service-linked role but it failed if it already exists.

Expected Behavior

Deploy successfully even if the service-linked role already exists.

Current Behavior

If the service-linked role is already created, errors occur as following in an EMR on EKS addon.

Resource handler returned message: "Service role name AWSServiceRoleForAmazonEMRContainers has been taken in this account, please try a different suffix.

Reproduction Steps

After creating the service-linked role by blueprints or other ways, deploy a new blueprint with the EMR on EKS addons.

Possible Solution

Skip creating the service-linked role.

AWS Batch AddOn tries checking if a service-linked role exists before creatring it, but it won't work well because Role.fromName() doesn't check the existance.
Generally, it would be difficult to create only non-existed resources in CDK.

Anyway, service-linked roles are shared resources, so I think it should not be created by blueprints.

Additional Information/Context

No response

CDK CLI Version

2.99.1

EKS Blueprints Version

1.12.0

Node.js Version

v18.16.1

Environment details (OS name and version, etc.)

macOS 12.4

Other information

No response

@sambaiz sambaiz added the bug Something isn't working label Oct 26, 2023
@shapirov103
Copy link
Collaborator

@youngjeong46 looks like the SLR is using a unique name and the uniqueness check fails. Please advise if there is a workaround at present and looking for the path forward to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants