(Teams): team manifest logical IDs are dependent on file order

[paulchambers]

Describe the bug

yaml-utils / applyYamlFromDir uses the index into the list of files as part of the logical ID for each manifest.

This results in the ID of each resource changing if the order of files in the directory changes.

Expected Behavior

Adding or removing manifests in a team directory should not result in logical ID changes

Current Behavior

Adding or removing manifests in a team directory results in unexpected logical ID changes and deployment errors

Reproduction Steps

1. Deploy a cluster with a team with a teamManifestDir and a manifest "b.yaml"

This manifest will get a logical ID containing b0

2. Add another manifest "a.yaml"

3. Run synth

You will now have two resources to add:

a0
b1

and one resource to remove:

b0

4. Run deploy

a0 will be added successfully
b1 will fail to be added as the kubectl handler considers it a new resource and uses create but the resource added by b0 still exists

5. Deployment will then fail and rollback

Possible Solution

Don't use the file index as part of the logical ID

Additional Information/Context

No response

CDK CLI Version

2.81.0 (build bd920f2)

EKS Blueprints Version

1.9.1

Node.js Version

v18.16.0

Environment details (OS name and version, etc.)

Windows 11

Other information

No response