Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsNodeTerminationHandlerAddOn does not work with SQS mode #392

Open
vumdao opened this issue May 20, 2022 · 1 comment
Open

AwsNodeTerminationHandlerAddOn does not work with SQS mode #392

vumdao opened this issue May 20, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@vumdao
Copy link
Contributor

vumdao commented May 20, 2022

Describe the bug

Issue: It works well with IMDS mode but got following error when using QUEUE mode

/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/private/uniqueid.ts:42
    throw new Error(`ID components may not include unresolved tokens: ${unresolvedTokens.join(',')}`);
          ^
Error: Resolution error: ID components may not include unresolved tokens: aws-${Token[TOKEN.620]}-nth-lifecycle-hook.
Object creation stack:
  at Execute again with CDK_DEBUG=true to capture stack traces
    at Object.makeUniqueId (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/private/uniqueid.ts:42:11)
    at EksBlueprint.allocateLogicalId (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/stack.ts:975:12)
    at EksBlueprint.getLogicalId (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/stack.ts:473:28)
    at CfnRole.synthesizeLogicalId (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/cfn-element.ts:131:25)
    at Object.produce (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/cfn-element.ts:59:64)
    at LazyString.resolve (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/lazy.ts:352:28)
    at RememberingTokenResolver.resolveToken (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/resolvable.ts:145:24)
    at RememberingTokenResolver.resolveToken (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/private/resolve.ts:282:18)
    at resolve (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/private/resolve.ts:208:51)
    at Object.resolve [as mapToken] (/home/workspace/github/aws-eks-blueprints-cdk/node_modules/aws-cdk-lib/core/lib/private/resolve.ts:115:77)

Subprocess exited with error 1

Expected Behavior

AwsNodeTerminationHandlerAddOn works well with QUEUE mode

Current Behavior

AwsNodeTerminationHandlerAddOn got error when using QUEUE mode

Reproduction Steps

Define AwsNodeTerminationHandlerAddOn with mode Mode.QUEUE

new AwsNodeTerminationHandlerAddOn({
    mode: Mode.QUEUE
  }),

Possible Solution

Ref: aws/aws-cdk#1423

Additional Information/Context

No response

CDK CLI Version

2.25.0

EKS Blueprints Version

1.0.1

Node.js Version

v16.13.0

Environment details (OS name and version, etc.)

Ubuntu

Other information

No response

@vumdao vumdao added the bug Something isn't working label May 20, 2022
@elamaran11
Copy link
Collaborator

@vumdao Do you still face this issue.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants