Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify warning around using clear_state=True with Logger() when using Powertools as a Lambda layer vs using other Lambda layers #4458

Open
1 task done
ChrisHills463 opened this issue Jun 6, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@ChrisHills463
Copy link

What were you searching in the docs?

I was reading about Logger()

Is this related to an existing documentation section?

https://docs.powertools.aws.dev/lambda/python/latest/core/logger/#clearing-all-state

How can we improve?

The documentation contains a warning Danger: This can have unintended side effects if you use Layers however I believe this relates to using other layers as opposed to using the Powertools layer itself.

Got a suggestion in mind?

Something like...

Danger: This can have unintended side effects if you use Layers other than Powertools.

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@ChrisHills463 ChrisHills463 added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Jun 6, 2024
@sthulb
Copy link
Contributor

sthulb commented Jun 7, 2024

Hi @ChrisHills463,

The docs are correct, it affects us – we should probably change the wording though here with what it actually affects.

@heitorlessa heitorlessa self-assigned this Jun 24, 2024
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Jun 24, 2024
@heitorlessa
Copy link
Contributor

Assigning to release it this Thursday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Working on it
Development

No branches or pull requests

3 participants