-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Powertools for AWS Lambda (Python) v3 #4189
Comments
There's a lot of overlap between the Event Handler, Event Source Data Classes, Parser, and Validation Is there a nice way to unify it all somehow? |
I agree. Since v3 will use pydantic by default, is there a need to maintain event source data classes? why not move to the parser's pydantic schemas exclusively? I suppose there are some gaps in coverage and missing schemas, but that can be fixed :) |
i contributed REST API event handler , GraphQL API eventhandler and Event Source Data Classes If what can be done here is not a major breaking change or a regression in performance it would be greatly appreciated, as we use Powertools for many internal tools at Fiserv. |
Hey Michael 🙏🏻 |
Hey everyone! Thanks for the contribution and for bringing ideas/suggestions to this RFC. We have no plans to remove features or do extreme refactoring to Powertools V3 utilities/codebase. This release mainly aims to drop Pydantic v1 in favor of v2 and resolve some pain points. When it comes to event source, we will be refactoring and introducing a small breaking change, but still using the same concept of creating objects from events and without any additional dependencies. Removing utilities such as Event Source or making Pydantic mandatory for the Event Handler, for example, could be a huge breaking change and would make it extremely hard for our customers to migrate from v2 to v3. I agree that we have some overlap between some utilities and could consider merging/removing them, but we can evaluate this in future releases, not in v3. Thanks |
Are you planning to remove the use of
|
Hi @trallnag! Yes, we are dropping support for Pydantic v1 and refactoring the code to use the new methods available in Pydantic v2. |
Hello everyone! We are making good progress with V3 and hope to have an alpha release in the next few weeks and then release the official version this month/early September. |
This is exciting! Thanks for the update @leandrodamascena |
Awesome, thank you! |
Hello everyone! We have a first draft of the upgrade guide. This should give you an idea of the changes you will need to make to migrate to v3. We will continue to make changes to this upgrade guide until we launch it. |
Hello everyone! While we are making improvements to the upgrade guide, we already have a development version for local testing or even for your development environment. We would love to hear your feedback on this new version. v3.0.0.dev10 - https://pypi.org/project/aws-lambda-powertools/3.0.0.dev10/ Thanks |
Thank you for advancing this product! |
Hi @Hatter1337! Thanks for using Powertools and giving us some ideas on what you want to see we investing time into it. But I'm curious about this:
We already support OpenAPI generation in V2. The experience is simple and you just need to write down your routes and access swagger or generate OpenAPI JSON Schema. https://docs.powertools.aws.dev/lambda/python/latest/core/event_handler/api_gateway/#openapi Are you talking about something different? Any improvement? I'm really curious to hear from you. |
This might not be the best place for this discussion, but I’ll respond here... I've been using Powertools for quite long time, and to be honest, I often end up writing the Swagger file manually, primarily because OpenAPI generation requires almost full descriptions: @router.get(
"/user/<id>",
summary="Get user data",
description="Get user data from ...",
response_description="User data",
responses={
200: {
"description": "Success",
"content": {"application/json": {"model": UserDataResponse}},
},
400: {
"description": "Bad request",
"content": {"application/json": {"model": BadRequestResponse}},
},
404: {
"description": "Not found",
"content": {"application/json": {"model": NotFoundResponse}},
},
},
tags=["User"],
) All of this is in the same file as the business logic, making it quite bulky and harder to manage. I'm not sure how it's implemented in FastAPI, but there it seems much simpler 🙊 Occasionally, I run into certain issues, one of which I've described here. Another example is that I haven’t been able to find information on how to add something similar to this when using @app.get("/swagger", include_in_schema=False)
def openapi():
return app.get_openapi_json_schema(
title="Awesome API",
servers=[servers],
security_schemes={
"apikey": APIKey(
name="X-API-KEY",
description="API KeY",
in_=APIKeyIn.header,
),
},
) Also, I prefer to split API endpoints across different Lambda functions - for example, having User CRUD in one Lambda function and authentication in another, rather than putting the entire API in a single Lambda function. However, with this approach, it's almost impossible to generate a unified OpenAPI/Swagger file for the whole API. That said, I still believe Powertools is an amazing framework, and I'm grateful to everyone who contributed to its development. I hope I can also be helpful to the community in the future. |
Where can we find the new doc for V3? |
This is now released under 3.0.0 version! |
Is this related to an existing feature request or issue?
#4067
Which Powertools for AWS Lambda (Python) utility does this relate to?
Other
Summary
We are excited to announce that we are starting a new major version (v3) for Powertools for AWS Lambda (Python). We are expediting a new major version to align with the scheduled Pydantic v1 end-of-life on June 30th, signalling the switch to much anticipated Pydantic v2. Pydantic plays a vital role and we care deeply about supply chain security. This release highlights our dedication to providing a secure and stable library that our customers trust.
Today, we already support both Pydantic v1 and v2. In this new major version, we will make Pydantic v2 the default, removing Pydantic v1. We will take this opportunity to introduce minor breaking changes to address common pain points. As always, we will provide an extensive upgrade guide to make this transition as smooth as possible.
Community
We invite the entire Powertools community, including users and contributors, to actively participate in this RFC. We greatly value the community's contribution, ideas, and willingness to solve problems or validate proposed changes.
Use case
The primary use case is to offer Pydantic v2. That includes a new Lambda Layer for each Python version since Pydantic v2 contains non-Python code (Rust). It future-proof Layers to contain any additional compiled dependency (like cryptography) without a new major version.
Additional key items on v3 backlog
Optional
in Event Source Data Classes to further reduce customers codeProposal
The action plan for this release with scope and tasks is as follows:
Quick summary (Work in progress - Items can be added or removed):
refactor theSSMProvider
class to implement theget_multiple
methodReturn emptyDict
orList
in Event Source Data Classes instead ofNone
event_parser
envelopes should handle unions of BaseModelsPydantic v2 managed layertracing.base.BaseProvider
resolved_headers_field
is not OptionalCreate a Powertools Lambda layer for each Python versionRemove any specific code for Pydantic v1Update Powertools documentation to add banner about v3Add theaws-encryption-sdk
dependency in the Powertools layerReview the methodextract_data_from_envelope
in JMESPath FunctionsSplit the code from theapi_gateway.py
file into several other files to ease maintenanceAdd support for v3 branch in the github actionsUnmarshal DynamoDB fields when usingDynamoDBStreamModel
Remove legacy code in the Metrics utility?Change the default TTL (cache) to 5 minutesUpdate boto3 version to 1.34.32Remove the flaglog_uncaught_exceptions
in the Logger utilityDeadlines
We plan to release the first version of v3 by the end of June/beginning of July.
Out of scope
We will not include in v3:
Potential challenges
Adding Pydantic v2 in the Powertools layer requires layers per Python version, so the effort to implement this is not yet clear.
Dependencies and Integrations
No response
Alternative solutions
No response
Acknowledgment
The text was updated successfully, but these errors were encountered: