Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: update jackson and aws-xray-recorder dependencies together #1538

Closed
1 of 2 tasks
roamingthings opened this issue Dec 13, 2023 · 4 comments · Fixed by #1556
Closed
1 of 2 tasks

Maintenance: update jackson and aws-xray-recorder dependencies together #1538

roamingthings opened this issue Dec 13, 2023 · 4 comments · Fixed by #1556
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers maven v2 Version 2
Milestone

Comments

@roamingthings
Copy link
Contributor

Summary

Jackson 2.16.0 introduces some breaking changes that require to update the AWS X-Ray Recorder dependencies to 2.15.0.

Why is this needed?

We need to be careful to update both dependencies at once to prevent breaking applications. There are other breaking changes in Jackson 2.16.0 (e.g. new behavior of DefaultPrettyPrinter) that may also affect this project. The DefaultPrettyPrinter is used in JacksonFactoryCopy.java

Which area does this relate to?

No response

Solution

Update both dependencies and check for any unwanted behavior

Acknowledgment

@roamingthings
Copy link
Contributor Author

roamingthings commented Dec 13, 2023

For reference: Full Jackson 2.16 release notes

@jeromevdl jeromevdl added v2 Version 2 good first issue Good for newcomers dependencies Pull requests that update a dependency file maven and removed triage labels Dec 14, 2023
@jeromevdl
Copy link
Contributor

Thanks for reporting this @roamingthings, we'll include this in v2.
Please note that we now restrict our development on v1 to the strict minimum (bug fixes and security patches) => See #1522

@scottgerring scottgerring added this to the v2 milestone Dec 21, 2023
@subhash686
Copy link

I would like to help with this.

@subhash686
Copy link

I created a PR against v2 branch. Did not see any breaking changes like compile errors or failed tests after updating the versions. Please review when you get a chance and advise if I need to run any extra steps in such cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers maven v2 Version 2
Projects
Status: Triage
4 participants