Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): Split parameters module up by parameter provider #1403

Merged
merged 51 commits into from
Dec 11, 2023

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Aug 29, 2023

Issue #, if available:
#1402

Description of changes:

Checklist

Outstanding Changes

  • Migration guide
  • Documentation
  • AspectJ test coverage

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@scottgerring scottgerring changed the title v2: Split parameters module up by parameter provider chore: v2 - Split parameters module up by parameter provider Aug 29, 2023
@scottgerring scottgerring linked an issue Aug 29, 2023 that may be closed by this pull request
2 tasks
@scottgerring scottgerring changed the base branch from main to v2 August 29, 2023 11:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v2@00d04c3). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##             v2    #1403   +/-   ##
=====================================
  Coverage      ?   76.41%           
  Complexity    ?      517           
=====================================
  Files         ?       67           
  Lines         ?     2107           
  Branches      ?      242           
=====================================
  Hits          ?     1610           
  Misses        ?      421           
  Partials      ?       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost good

scottgerring and others added 2 commits December 11, 2023 12:43
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
…/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java

Co-authored-by: Jérôme Van Der Linden <[email protected]>
Copy link
Contributor

@jeromevdl jeromevdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 120 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring merged commit 6b0fe5a into v2 Dec 11, 2023
15 of 16 checks passed
@scottgerring scottgerring deleted the v2-split-params branch December 11, 2023 13:13
@jeromevdl
Copy link
Contributor

:bananadance:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Split powertools-parameters into submodules
3 participants