-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v2): Split parameters module up by parameter provider #1403
Conversation
311c1da
to
2f79e7c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v2 #1403 +/- ##
=====================================
Coverage ? 76.41%
Complexity ? 517
=====================================
Files ? 67
Lines ? 2107
Branches ? 242
=====================================
Hits ? 1610
Misses ? 421
Partials ? 76 ☔ View full report in Codecov by Sentry. |
.../test/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java
Outdated
Show resolved
Hide resolved
.../test/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java
Outdated
Show resolved
Hide resolved
.../test/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java
Outdated
Show resolved
Hide resolved
.../test/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java
Outdated
Show resolved
Hide resolved
...amodb/src/main/java/software/amazon/lambda/powertools/parameters/dynamodb/DynamoDbParam.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost good
Co-authored-by: Jérôme Van Der Linden <[email protected]>
Co-authored-by: Jérôme Van Der Linden <[email protected]>
.../test/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java
Outdated
Show resolved
Hide resolved
…/java/software/amazon/lambda/powertools/parameters/appconfig/AppConfigProviderTest.java Co-authored-by: Jérôme Van Der Linden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
:bananadance: |
Issue #, if available:
#1402
Description of changes:
Checklist
Outstanding Changes
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.