Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudTrail Data Events S3 bucket is created even if aft_feature_cloudtrail_data_events is set to false #464

Open
agnasillo opened this issue Jun 7, 2024 · 1 comment
Labels
bug Something isn't working pending investigation Issue needs further investigation

Comments

@agnasillo
Copy link

Terraform Version & Prov:

AFT Version: 1.12.0
(Can be found in the AFT Management Account in the SSM Parameter /aft/config/aft/version)

Terraform Version & Provider Versions
Please provide the outputs of terraform version and terraform providers from within your AFT environment

terraform version

1.6.0

terraform providers

hashicorp/aws = 5.21.0

Bug Description
S3 bucket aws-aft-logs-${ACCOUNT-ID}-${REGION} is created even if aft_feature_cloudtrail_data_events is set to false

To Reproduce
Steps to reproduce the behavior:

  1. Set aft_feature_cloudtrail_data_events as false for aws-ia/control_tower_account_factory/aws module.
  2. Login into the AFT Management account
  3. See that s3 bucket aws-aft-logs-${ACCOUNT-ID}-${REGION} exists, e.g. aws-aft-logs-11111111111-us-east-1 is created

Expected behavior
Bucket should not be created and remain empty if user opts out of cloudtrail data events feature.

Related Logs
N/A

Additional context
N/A

@agnasillo agnasillo added bug Something isn't working pending investigation Issue needs further investigation labels Jun 7, 2024
@snebhu3
Copy link
Collaborator

snebhu3 commented Jun 21, 2024

@anasillo thank you for reporting this.
I will create an internal backlog to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending investigation Issue needs further investigation
Projects
None yet
Development

No branches or pull requests

2 participants