From e535bd9aaaf5137d248126824a6e9a504fe3695c Mon Sep 17 00:00:00 2001 From: michaelhtm <98621731+michaelhtm@users.noreply.github.com> Date: Wed, 23 Apr 2025 14:47:26 -0700 Subject: [PATCH] chore: warn of ChangeBatch eventual deprecation --- apis/v1alpha1/ack-generate-metadata.yaml | 6 +++--- pkg/resource/record_set/sdk.go | 4 +++- .../hooks/record_set/sdk_create_post_build_request.go.tpl | 4 +++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml index b853038..2018f8d 100755 --- a/apis/v1alpha1/ack-generate-metadata.yaml +++ b/apis/v1alpha1/ack-generate-metadata.yaml @@ -1,8 +1,8 @@ ack_generate_info: - build_date: "2025-03-27T16:26:40Z" - build_hash: 980cb1e4734f673d16101cf55206b84ca639ec01 + build_date: "2025-04-23T16:43:40Z" + build_hash: 0909e7f0adb8ffe4120a8c20d5d58b991f2539e9 go_version: go1.24.1 - version: v0.44.0 + version: v0.44.0-3-g0909e7f api_directory_checksum: b920521646bacef1fba9d0b97a423d11565c7a60 api_version: v1alpha1 aws_sdk_go_version: v1.32.6 diff --git a/pkg/resource/record_set/sdk.go b/pkg/resource/record_set/sdk.go index af89c37..e670e0e 100644 --- a/pkg/resource/record_set/sdk.go +++ b/pkg/resource/record_set/sdk.go @@ -325,7 +325,9 @@ func (rm *resourceManager) sdkCreate( if err != nil { return nil, err } - + if desired.ko.Spec.ChangeBatch != nil { + rlog.Info("WARNING: ChangeBatch field is no-op, and will be removed soon!") + } action := svcsdktypes.ChangeActionCreate recordSet, err := rm.newResourceRecordSet(ctx, desired) if err != nil { diff --git a/templates/hooks/record_set/sdk_create_post_build_request.go.tpl b/templates/hooks/record_set/sdk_create_post_build_request.go.tpl index 2c8e621..e05a0f2 100644 --- a/templates/hooks/record_set/sdk_create_post_build_request.go.tpl +++ b/templates/hooks/record_set/sdk_create_post_build_request.go.tpl @@ -1,4 +1,6 @@ - + if desired.ko.Spec.ChangeBatch != nil { + rlog.Info("WARNING: ChangeBatch field is no-op, and will be removed soon!") + } action := svcsdktypes.ChangeActionCreate recordSet, err := rm.newResourceRecordSet(ctx, desired) if err != nil {