New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] Is encoding.Stringify required? #227

Open

msummers-nr opened this issue Oct 25, 2023 · 0 comments

Contributor

msummers-nr commented Oct 25, 2023 •

edited

Loading

I'm curious if use of encoding.Stringify is actually required.

I was having issues with contract tests failing due to Request/Response not matching. Digging into that issue I found several bugs in Stringify:

integers quoted in the Response
nested structs not honoring the omitempty tag

As a work around I commented out the use of Stringify in cfn.newResponse and everything works- that leads me to wonder why Stringify exists.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment