Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer proguard rules are too broad #3560

Open
alipov opened this issue Apr 8, 2024 · 1 comment
Open

Consumer proguard rules are too broad #3560

alipov opened this issue Apr 8, 2024 · 1 comment
Labels
core Issues with the AWS Android Core library feature-request Request a new feature improvement Improvements and suggestions from community

Comments

@alipov
Copy link

alipov commented Apr 8, 2024

Describe the bug
SDK's consumer proguard rules include the following rule that affects all enum classes in hosting application (not just the ones belonging to this SDK):

# Enums are not obfuscated correctly in combination with Gson
-keepclassmembers enum * { *; }

There are enum classes in my application whose members I want to be obfuscated, but the above rule prevents that.

To Reproduce
Create an app with an enum class, consume it somewhere. Build a release version with minification/obfuscation enabled.

Which AWS service(s) are affected?
None, but it affects the hosting app.

Expected behavior
The SDK doesn't affect the obfuscation of host application's enum members.
For example, consider to reduce rule's scope only to classes in com.amazonaws or com.amazon packages:

-keepclassmembers enum com.amazonaws.**,com.amazon.** { *; }

Environment Information (please complete the following information):

  • AWS Android SDK Version: latest
  • Device: any
  • Android Version: any
  • Specific to simulators: no
@joon-won
Copy link
Member

joon-won commented Apr 8, 2024

Hi @alipov, our team will take a look into the issue

@joon-won joon-won added bug Something isn't working improvement Improvements and suggestions from community core Issues with the AWS Android Core library and removed bug Something isn't working labels Apr 8, 2024
@tylerjroach tylerjroach added the feature-request Request a new feature label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues with the AWS Android Core library feature-request Request a new feature improvement Improvements and suggestions from community
Projects
None yet
Development

No branches or pull requests

3 participants