Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Lombok dependency and project version to 1.18.30 #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alecharp
Copy link

@alecharp alecharp commented Sep 26, 2023

This updates the Lombok dependency to version 1.18.30 so that the plugin can support Java 21.

Closes #172.
Closes #174.
Resolves #179.

Testing

I could build the project locally and use it to build and test Google Compute Engine plugin for Jenkins.

Copy link

@sepe81 sepe81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the project version could be 1.18.30.0-SNAPSHOT instead of 1.18.30.1-SNAPSHOT?

@alecharp
Copy link
Author

Maybe the project version could be 1.18.30.0-SNAPSHOT instead of 1.18.30.1-SNAPSHOT?

I fixed that in b10621e

@sepe81
Copy link

sepe81 commented Sep 27, 2023

@awhitford thank you for this project. Would it be possible to merge this PR and release a new version?

@alecharp
Copy link
Author

@awhitford would it be possible to get your review on this? Thanks.

@jkosternl
Copy link

I just sent Anthony an email if he can merge this PR and publish the new artifacts, or find new developers he can trust, to take over this maintenance process. Hope he responds..

rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request Apr 30, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
hbenali pushed a commit to Meeds-io/maven-parent-pom that referenced this pull request May 2, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
hbenali pushed a commit to Meeds-io/maven-parent-pom that referenced this pull request May 2, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
hbenali pushed a commit to Meeds-io/maven-parent-pom that referenced this pull request May 2, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
hbenali pushed a commit to Meeds-io/maven-parent-pom that referenced this pull request May 2, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 3, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/meeds#1932
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 3, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/meeds#1932
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 3, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/MIPs#91
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 14, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 15, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 15, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 16, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 16, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/MIPs#91
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 16, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/MIPs#91
rdenarie added a commit to Meeds-io/maven-parent-pom that referenced this pull request May 22, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/MIPs#91
exo-swf pushed a commit to Meeds-io/maven-parent-pom that referenced this pull request May 22, 2024
Before this fix, we use lombok-maven-plugin version 1.18.20.0 which use lombok 1.18.20 which is not compatible with jdk21.
This fix is a workaround waiting this pr to be merged : awhitford/lombok.maven#180 and a new artifact released

Resolves Meeds-io/MIPs#91
@fxrobin
Copy link

fxrobin commented Sep 13, 2024

Hi there. Is it possible to release this version? Because delomboking in Java 21 is important. I prefer not to fallback to maven AntRun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delombok fails on Java 21
5 participants