Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination markup issues #218

Open
arraypress opened this issue Nov 18, 2018 · 0 comments
Open

Pagination markup issues #218

arraypress opened this issue Nov 18, 2018 · 0 comments

Comments

@arraypress
Copy link
Contributor

In the Themedd 1.1 branch, pagination of the various third party extensions such as Commissions, Frontend Submissions, Software Licensing, etc is not being styled for due to changes in the HTML markup for the new version of Themedd and how pagination markup is now handled via the Bootstrap framework. In most cases this extends to all template files as well (download/purchase history, subscriptions, etc.).

A lot of functions directly call edd_pagination, which builds the actual links using the paginate_links function.

To resolve this issue, I believe a few things need to happen, ideally the edd_pagination function would become hook-able, as-in replace the function code within it with a do_action so it can be unhooked and over-ridden by themes as needed. We would then have a custom pagination function within Themedd that accounted for Bootstrap markup. This could include a filter to make it possible to show different styles of Bootstrap pagination such as with numbers, without, etc. I seen this basic example of building WordPress pagination with Bootstrap support here: http://dancameron.org/code/wordpress-paginate_links-customization-bootstrap-compatibility/

A few extensions would then need to be updated to call the edd_pagination function, since Commissions (and a few others) build it all in-line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant