Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button labels inconsistency #9600

Open
dashkevych opened this issue Dec 6, 2022 · 0 comments
Open

Button labels inconsistency #9600

dashkevych opened this issue Dec 6, 2022 · 0 comments
Labels
type-bug workflow-needs-replication workflow-pending-triage Items that need to be triaged and reviewed before they are worked on.

Comments

@dashkevych
Copy link

Bug Report

Expected behavior

It would be better if button labels were only with the first word capitalized while other words were lowercase.

As it is shown on the button regarding discount in a screenshot below.

In that case, it would make the button styles more flexible.

Thus, the user would be able to fit labels to the website's design system.

Uppercase all words:

button {
  text-transform: uppercase;
}

Lowercase all words:

button {
  text-transform: lowercase;
}

Capitalize all words:

button {
  text-transform: capitalize;
}

Actual behavior

button-label-issue

Some EDD buttons show a label with the first word capitalized and other words lowercased, like the button for Discount section.

While other buttons show a label with capitalized all words, like the button from Software Licensing add-on.

As a result, it causes inconsistency in the plugin's elements.

The problem is that those buttons that show a label with capitalized all words are "hard-coded".

Example: "Renew An Existing License".

Thus, it's not possible to have a label with the first word capitalized and other words lowercased.

Steps to reproduce the behavior

  1. Enable Discount section
  2. Enable Software Licensing section
  3. Allow renewal
  4. Open checkout page with added product

Information (if a specific version is affected):

PHP Version: 7.4.1

EDD Version (or branch): 3.1.0.3

WordPress Version: 6.1.1

@dashkevych dashkevych added type-bug workflow-needs-replication workflow-pending-triage Items that need to be triaged and reviewed before they are worked on. labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug workflow-needs-replication workflow-pending-triage Items that need to be triaged and reviewed before they are worked on.
Projects
None yet
Development

No branches or pull requests

1 participant