Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading doc about SSL vs STARTTLS config #132

Open
gggeek opened this issue Apr 3, 2024 · 1 comment
Open

Misleading doc about SSL vs STARTTLS config #132

gggeek opened this issue Apr 3, 2024 · 1 comment

Comments

@gggeek
Copy link

gggeek commented Apr 3, 2024

I think the comment on line https://github.com/awesomemotive/WP-Mail-SMTP/blame/023e5bc91963e0ddc1b3955e60d0de972fdc3604/wp_mail_smtp.php#L71 is wrong, or at least misleading.

Looking at the phpmailer code, it seems to be the opposite:
WPMS_SSL='ssl' -> an implicit-ssl connection will be used to connect the server (where ssl might be tls 1.2 in fact)
WPMS_SSL='tls' -> a plain connection + starttls will be used

@gggeek
Copy link
Author

gggeek commented Apr 3, 2024

While at it, the note for WPMS_SMTP_AUTOTLS "True turns it on, false turns it off" might be detailed a bit more: it means "do use startls when the server declares support for it, openssl is available to php and the connection is not using implicit ssl"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant