Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip corrupted data in an SRT file #50

Open
1 task done
CurryKitten opened this issue May 24, 2024 · 0 comments
Open
1 task done

Option to skip corrupted data in an SRT file #50

CurryKitten opened this issue May 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@CurryKitten
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Software version

3.3

What operating system are you using?

MacOS 11.7.10

What GPU are you using?

No response

What problem did you encounter?

This has happened a few times - maybe from me crashing a quad - but I sometimes get the situation where I open some files and the SRT file doesn't appear to open. If I look at the little cli window I get, I can see the error message:

2024-05-24T09:52:12.299280Z ERROR backend::srt::srt_file: error: Failed to parse data from STR file, source: field `bitrate_mbps` parse failed.
    at backend/src/srt/srt_file.rs:18
    in backend::srt::srt_file::open with path: "/Users/wayneandrews/Desktop/WalkSnail/Recordings/AvatarG0032.srt"

If I then look in the SRT file, I can indeed see that we have some odd/corrupted data in the last line of the file:

229
00:00:34,016 --> 00:00:34,150
Signal:0 CH:1 FlightTime:35 SBat:15.9V GBat:16.5V Delay:94ms Bitrate:1.7Mbps Distance:263m

230
00:00:34,150 --> 00:00:34,200
Signal:0 CH:-- FlightTime:-- SBat:--V GBat:--V Delay:--ms Bitrate:--Mbps Distance:--m

If I go ahead and simply edit the SRT file to take the dodgy entry out (making sure to remove the blank line as well, as it also throws a wobbly at that. Then I can process the file without a problem.

My thinking that it would be useful to include an option where you could ignore any lines you couldn't parse - perhaps with some warnings, rather than not let the use see any of his recording with the OSD

Link to screenshots

No response

Link to video, OSD and font files

No response

Log output

No response

@CurryKitten CurryKitten added the bug Something isn't working label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant