Release with a new versioning scheme?

[MCUdude]

@stefanrueger @mcuee I finally upgraded macOS on my old computer, and now libserialport is more broken than before. With macOS 10.14, only the CP210x chips didn't work properly with libserialport, but now there are a bunch of others as well, including the CH340 and possibly the FT231X.

I took the liberty to fork the libserialport repo so I could merge the really simple bugfix. However, we probably should release a version of this fork, so package managers like Brew can utilize it.

The last version of libserialport is 0.1.1. Which version number should I bump this up to? Ideally, I don't want it to conflict with the "official" libserialport repo if that ever gets a new release sometime in the future.

[mcuee]

We can add a version marker, like 0.1.2-avrdude.

[MCUdude]

Good idea. Done!

[mcuee]

@MCUdude

Not really done. You have to modify at least the following file.
https://github.com/avrdudes/libserialport/blob/master/configure.ac

# libserialport package version number (NOT the same as shared lib version!).
m4_define([sp_package_version_major], [0])
m4_define([sp_package_version_minor], [1])
m4_define([sp_package_version_micro], [1])
m4_define([sp_package_version], [sp_package_version_major.sp_package_version_minor.sp_package_version_micro])

Maybe change the above to

# libserialport package version number (NOT the same as shared lib version!).
m4_define([sp_package_version_major], [0])
m4_define([sp_package_version_minor], [1])
m4_define([sp_package_version_micro], [2-avrdude])
m4_define([sp_package_version], [sp_package_version_major.sp_package_version_minor.sp_package_version_micro])

But I am not so sure if this is the right way to go to add the version marker, maybe need more more field.

@ndim
Would you please help here? Thanks.

[ndim]

I wrote #3 with libserialport-0.1.1-avrdude1 before I saw the release tag 0.1.2-avrdude which actually contains software which weirdly says it is libserialport-0.1.1.

[mcuee]

@ndim
Thanks. I think it is okay for #3 to use 0.1.3-avrdude.

[ndim]

BTW, https://github.com/avrdudes/libserialport says in the "About" region that

Read-only mirror of the official repo at git://sigrok.org/libserialport. Pull requests welcome. Please file bugreports at sigrok.org/bugzilla.

I think it would make sense to replace that text with something like

This is a fork of git://sigrok.org/libserialport to fix bugs and integrate libserialport with the avrdude project and push those changes back to upstream.

[ndim]

I have taken a look at cmake, and cmake insists version numbers are numbers only, 1.2.3 or 1.2.3.4 at maximum. So if we want to keep the cmake version number the same as autoconf, I would suggest keeping the first three numbers from upstream and just adding one number of our own.

[mcuee]

@ndim

I think that is a good proposal.

[mcuee]

I think it would make sense to replace that text with something like

This is a fork of git://sigrok.org/libserialport to fix bugs and integrate libserialport with the avrdude project and push those changes back to upstream.

Thanks. Done.

[MCUdude]

So how can we complete this? I'm not qualified to review #3. As mentioned earlier, the goal is to release a slightly modified version of libserialport that macOS package managers (brew, macports?) can use when building Avrdude.

[mcuee]

@MCUdude and @ndim

Maybe we can have a simplified PR (extracted from PR #3) just to address this issue.

[mcuee]

@MCUdude and @ndim

I think we can just merge PR #3 and then improve from there. It is working for both CMake and auto-tools build.

Any objections?