Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement radio field #3140

Closed
Paul-Bob opened this issue Aug 14, 2024 · 10 comments · Fixed by #3425 or avo-hq/docs.avohq.io#313
Closed

Implement radio field #3140

Paul-Bob opened this issue Aug 14, 2024 · 10 comments · Fixed by #3425 or avo-hq/docs.avohq.io#313
Assignees
Labels
Feature Good first issue Good for newcomers Help wanted We could use some help with this

Comments

@Paul-Bob
Copy link
Contributor

Paul-Bob commented Aug 14, 2024

Context

Similar to the boolean group field but using radio input so the options become exclusive

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/radio

Originally requested here

@Paul-Bob Paul-Bob added this to Issues Aug 14, 2024
@Paul-Bob Paul-Bob moved this to To Do in Issues Aug 14, 2024
Copy link
Contributor

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Aug 31, 2024
Copy link
Contributor

Closing this because there was no activity for the past 15 days. Feel free to reopen if new information pops up ✌️

@github-project-automation github-project-automation bot moved this from To Do to Done in Issues Sep 15, 2024
@Paul-Bob Paul-Bob removed the Stale label Sep 16, 2024
@Paul-Bob Paul-Bob reopened this Sep 16, 2024
@Paul-Bob Paul-Bob moved this from Done to To Do in Issues Sep 16, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

This issue has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Oct 2, 2024
@Paul-Bob Paul-Bob removed the Stale label Oct 2, 2024
@adrianthedev adrianthedev added Help wanted We could use some help with this Good first issue Good for newcomers labels Oct 3, 2024
@zhephyn
Copy link
Contributor

zhephyn commented Oct 31, 2024

Hey @Paul-Bob. I'll take up this one

@Paul-Bob
Copy link
Contributor Author

Great @zhephyn! This one is challenging! Let me know if you find any obstacles

@Paul-Bob
Copy link
Contributor Author

Thank you!

@zhephyn
Copy link
Contributor

zhephyn commented Nov 5, 2024

Hey @Paul-Bob. I'm trying to access the discord channel where the feature is stated to have been requested for initially, but it seems the link is broken. Could you provide some more context about the feature to be implemented or maybe the specific page in the application where the feature ought to be implemented. Thank you

@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Nov 5, 2024

Hey @zhephyn, there's not much happening on the Discord thread, it's mainly here to track the source of the original request.

Could you provide some more context about the feature to be implemented or maybe the specific page in the application where the feature ought to be implemented. Thank you

Sure. The idea is to implement a new field that will allow this DSL:

field :gender, as: :radio

This will use a radio input element: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/radio

Let's take the boolean_group field as a reference for structuring it:

  • Field definition file here: lib/avo/fields/boolean_group_field.rb
  • Component files here: app/components/avo/fields/boolean_group_field

We need to build a file to keep the radio field and components.

@zhephyn
Copy link
Contributor

zhephyn commented Nov 15, 2024

Hey @Paul-Bob. It seems this issue received a PR that could result into it becoming a closed one. I was still working through my solution, but now I'm not sure how to proceed. Should i abandon working on and submitting a PR for this issue and pick up another one? Or should i continue working on it? Any guidance is appreciated. Thanks in advance.

@Paul-Bob
Copy link
Contributor Author

The PR for this issue is on track to be merged soon, which will indeed close it.

You're still welcome to open a PR for your current work if you'd like some feedback, though it won't be merged, I can review it to provide any insights or suggestions

I'm sorry that it happened again. I've just created this issue: #3426. If you're interested, we can assign it exclusively to you. Let me know!

Thank you @zhephyn !

@github-project-automation github-project-automation bot moved this from To Do to Done in Issues Nov 18, 2024
@thiagoyoussef thiagoyoussef mentioned this issue Nov 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Good first issue Good for newcomers Help wanted We could use some help with this
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants