Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject csv upload errors #803

Open
1t5j0y opened this issue Oct 9, 2024 · 1 comment
Open

Subject csv upload errors #803

1t5j0y opened this issue Oct 9, 2024 · 1 comment
Assignees

Comments

@1t5j0y
Copy link
Contributor

1t5j0y commented Oct 9, 2024

https://avni.freshdesk.com/a/tickets/4653

Issues:

  1. Empty "Date Of Birth Verified" value causes a null pointer exception
  2. If SubjectType registration location setting is not configured, "No matching location types found. If subject type has registration locations then only those will be used for matching." is always thrown even though valid location types exist.

documentation for reg., location

AC:

  • "Date of Birth Verified" field should not be a mandatory field. If nothing input in this column, it should be considered not verified and hence false.
  • If 'Location type where this subject can be registered' is not configured in the subject type, it should allow the subject to be registered via CSV at the lowest level. If not all addresses until the lowest is mentioned show the error "Mention all the locations in the location hierarchy needed to register the subject."
  • If there are multiple location hierarchies and 'Location type where this subject can be registered' is not configured, then the subject should be allowed to be registered in any one of the two hierarchies. This is what is done/allowed when registering via mobile app

Image

  • If 'Location type where this subject can be registered' is configured, then that should be respected. If extra address levels are there in the CSV it should not fail.
  • Add a tooltip on 'Location type where this subject can be registered', stating 'If this is not configured, subjects can be registered only at location type with the lowest level.'

Image

Inputs:

DOB verified -? need - atleast data can be retained?

@1t5j0y 1t5j0y self-assigned this Oct 30, 2024
1t5j0y added a commit that referenced this issue Oct 31, 2024
- Date of birth verified is non-mandatory. Defaults to false if not provided.
- Respect custom registration locations (or lower) if configured for subject type.
- Only allow registration at lowest address level locations if no custom registration location configuration for subject type.
1t5j0y added a commit to avniproject/avni-webapp that referenced this issue Oct 31, 2024
@1t5j0y
Copy link
Contributor Author

1t5j0y commented Oct 31, 2024

Additional AC:

Respected valid registration location in subject external write APIs as discussed in #785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA Ready
Development

No branches or pull requests

1 participant