Skip to content

Commit b4c2b17

Browse files
committed
Revert "CI/Makefile: disable uninlined_format_args clippy lint"
This reverts commit 4964b44. The main reason that uninlined_format_args lint was disabled in Rust Driver's CI/Makefile was that inlined variables in format strings had spotty support in rust-analyzer: rust-analyzer did not support renaming variables inside format strings. Fortunately, rust-analyzer recently gained support for renaming variables in format strings: rust-lang/rust-analyzer#16027, therefore 4964b44 can now be reverted. Moreover, Rust 1.67.1 downgraded uninlined_format_args to pedantic, meaning that it's disabled by default and we don't have to disable it manually. If it's ever promoted back to a enforced rule by default, we'll be ready to deal with it again (with a proper rust-analyzer support) - not addressing it now to avoid merge conflicts with other bigger planned PRs. Closes scylladb#643
1 parent 87908f3 commit b4c2b17

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.github/workflows/rust.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
- name: Format check
3030
run: cargo fmt --verbose --all -- --check
3131
- name: Clippy check
32-
run: cargo clippy --verbose --all-targets -- -Aclippy::uninlined_format_args
32+
run: cargo clippy --verbose --all-targets
3333
- name: Cargo check without features
3434
run: cargo check --all-targets --manifest-path "scylla/Cargo.toml" --features ""
3535
- name: Cargo check with all serialization features

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ check-without-features:
2727

2828
.PHONY: clippy
2929
clippy:
30-
RUSTFLAGS=-Dwarnings cargo clippy --all-targets -- -Aclippy::uninlined_format_args
30+
RUSTFLAGS=-Dwarnings cargo clippy --all-targets
3131

3232
.PHONY: test
3333
test: up

0 commit comments

Comments
 (0)