Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove options from the test-title rule #185

Closed
novemberborn opened this issue Jan 29, 2018 · 3 comments · Fixed by #224
Closed

Remove options from the test-title rule #185

novemberborn opened this issue Jan 29, 2018 · 3 comments · Fixed by #224
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@novemberborn
Copy link
Member

novemberborn commented Jan 29, 2018 •
edited by issuehunt-oss bot
Loading

Issuehunt badges

When avajs/ava#1669 ships tests will always be required to have a title. This makes the current test-title options obsolete.

IssueHunt Summary

gmartigny gmartigny has been rewarded.

Sponsors (Total: $30.00)

Tips
@novemberborn
Copy link
Member Author

Looking at the rule implementation I think it should be tweaked so it only errors if the first argument is a function. If it's a reference or an array then assume it's for a macro that provides a title.

@sindresorhus sindresorhus changed the title Remove options from test-title Remove options from the test-title rule Jul 14, 2018
@IssueHuntBot
Copy link

@IssueHunt has funded $30.00 to this issue.

GMartigny pushed a commit to GMartigny/eslint-plugin-ava that referenced this issue Mar 27, 2019
test-title only errored when first argument is a function
5bb0a4b 
fix avajs#185
@GMartigny GMartigny mentioned this issue Mar 27, 2019
Merged
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels May 17, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $27.00 to @GMartigny. See it on IssueHunt

  • 💰 Total deposit: $30.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $3.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove options from the test-title rule GMartigny/eslint-plugin-ava
3 participants
@novemberborn @sindresorhus @IssueHuntBot