Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support post and pre hooks #76

Open
ccharlesgb opened this issue Jul 17, 2024 · 0 comments
Open

Support post and pre hooks #76

ccharlesgb opened this issue Jul 17, 2024 · 0 comments
Assignees

Comments

@ccharlesgb
Copy link
Collaborator

Context

The dry runner does not evaluate whether post and pre hooks are valid syntax.
Adding this should be fairly easy, we just need to load the pre and post hook in the manifest and check if dry running the post/pre-hook will succeed.

Caveat

If the post/pre-hook runs DDL that creates/alters/deletes tables/views (i.e causes a schema change). Then the predicted schema of the dbt project will be incorrect. This could cause false positives/negatives in the dry run result. But this is not great practice as it is working around the materialisations provided by dbt.

@ccharlesgb ccharlesgb self-assigned this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant