Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow screens hide menu #2

Open
mrmanc opened this issue Jan 17, 2024 · 0 comments
Open

Narrow screens hide menu #2

mrmanc opened this issue Jan 17, 2024 · 0 comments

Comments

@mrmanc
Copy link
Member

mrmanc commented Jan 17, 2024

There was a menu button which did nothing. I suspect someone forgot to wire up the JS to show the menu. It’s available on the menu-button-present-but-inactive branch. The code for the menu button was removed in 1f5288d.

mrmanc added a commit that referenced this issue Jan 17, 2024
In narrow viewports, a menu button was visible which had no behaviour associated with it. I believe this was intended to show the menu which is hidden on narrow viewports. We don't really use the menu at the moment as we don't have other pages. This may be more important if we introduce more pages into the blog, for example a video page. I've created a `menu-button-present-but-inactive` branch with these pages and issue #2 representing the fact that in narrow screens there will be no way to see the menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant