From c9b6c58b3a300c9ca27a6489b62a1e754ce49c39 Mon Sep 17 00:00:00 2001
From: Xiaodai Wang <xiaodwan@redhat.com>
Date: Mon, 23 Sep 2024 17:29:29 +0800
Subject: [PATCH] RAS: add new case for RAS feature support

Signed-off-by: Xiaodai Wang <xiaodwan@redhat.com>
---
 libvirt/tests/cfg/features/ras.cfg | 14 +++++++
 libvirt/tests/src/features/ras.py  | 62 ++++++++++++++++++++++++++++++
 spell.ignore                       |  1 +
 3 files changed, 77 insertions(+)
 create mode 100644 libvirt/tests/cfg/features/ras.cfg
 create mode 100644 libvirt/tests/src/features/ras.py

diff --git a/libvirt/tests/cfg/features/ras.cfg b/libvirt/tests/cfg/features/ras.cfg
new file mode 100644
index 0000000000..ecab1808fd
--- /dev/null
+++ b/libvirt/tests/cfg/features/ras.cfg
@@ -0,0 +1,14 @@
+- features.ras:
+    type = ras
+    start_vm = no
+    only aarch64
+    func_supported_since_libvirt_ver = (10, 4, 0)
+    unsupported_err_msg = "Ras feature is not supported on current version."
+    variants:
+        - on:
+          ras_state = on
+        - off:
+          ras_state = off
+    variants:
+        - positive_test:
+            status_error = "no"
diff --git a/libvirt/tests/src/features/ras.py b/libvirt/tests/src/features/ras.py
new file mode 100644
index 0000000000..ed9af4a850
--- /dev/null
+++ b/libvirt/tests/src/features/ras.py
@@ -0,0 +1,62 @@
+import logging
+
+from virttest import virsh
+from virttest import libvirt_version
+from virttest.libvirt_xml.vm_xml import VMXML
+from virttest.utils_libvirt import libvirt_vmxml
+from virttest.utils_test import libvirt
+
+LOG = logging.getLogger('avocado.' + __name__)
+
+
+def run(test, params, env):
+    """
+    Test the ras feature
+    1. Enable 'ras=on/off' in a guest
+    2. check the xml and qemu cmd line
+    """
+    # Ras feature supported since 10.4.0.
+    libvirt_version.is_libvirt_feature_supported(params)
+
+    ras_state = params.get("ras_state")
+
+    def check_dumpxml():
+        """
+        Check whether the added devices are shown in the guest xml
+        """
+        xpath = [{'element_attrs': [".//ras[@state='%s']" % ras_state]}]
+        # Check ras state
+        vm_xml = VMXML.new_from_dumpxml(vm_name)
+        libvirt_vmxml.check_guest_xml_by_xpaths(vm_xml, xpath)
+
+    def check_qemu_cmd_line():
+        """
+        Check whether the ras feature is shown in the qemu cmd line
+        """
+        pattern = r"-machine.*ras=%s" % ras_state
+        libvirt.check_qemu_cmd_line(pattern)
+
+    vm_name = params.get("main_vm", "avocado-vt-vm1")
+    vm = env.get_vm(vm_name)
+
+    vm_xml = VMXML.new_from_dumpxml(vm_name)
+    vm_xml_backup = vm_xml.copy()
+    LOG.debug("vm xml is %s", vm_xml_backup)
+
+    if vm.is_alive():
+        vm.destroy()
+
+    try:
+        features_xml = vm_xml.features
+        if features_xml.has_feature('ras'):
+            features_xml.remove_feature('ras')
+        features_xml.ras = ras_state
+        vm_xml.features = features_xml
+        vm_xml.sync()
+        virsh.start(vm_name, ignore_status=False)
+        check_dumpxml()
+        check_qemu_cmd_line()
+    finally:
+        if vm.is_alive():
+            virsh.destroy(vm_name)
+        vm_xml_backup.sync()
diff --git a/spell.ignore b/spell.ignore
index c18394405c..902e06e889 100644
--- a/spell.ignore
+++ b/spell.ignore
@@ -826,6 +826,7 @@ qxl
 QXL
 qxldod
 Radix
+ras
 rases
 rawio
 rbd