Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore-prometheus-metrics flag not implemented for Spanner #2089

Open
srlightbody opened this issue Oct 8, 2024 · 0 comments
Open

datastore-prometheus-metrics flag not implemented for Spanner #2089

srlightbody opened this issue Oct 8, 2024 · 0 comments
Labels
area/observability Affects telemetry data kind/bug Something is broken or regressed

Comments

@srlightbody
Copy link

What platforms are affected?

linux

What architectures are affected?

amd64

What SpiceDB version are you using?

1.37.0, also tested v1.33.1-hotfix-enterprise.v1.hotfix.v1

Steps to Reproduce

Configure a spanner datastore with SpiceDB
Run spicedb with --datastore-prometheus-metrics set to false and Prometheus configured
Curl the configured metrics path that is serving SpiceDB metrics
All spanner metrics will still be visible, spicedb_cloud_google_com_go_spanner_gfe_latency_count for example.

Expected Result

All spanner datastore metrics are not exposed on SpiceDBs prometheus endpoint when the datastore-prometheus-metrics flag is set to false.

Actual Result

All spanner datastore metrics continue to be exposed on SpiceDBs prometheus endpoint when the datastore-prometheus-metrics flag is set to false.

@srlightbody srlightbody added the kind/bug Something is broken or regressed label Oct 8, 2024
@jzelinskie jzelinskie added the area/observability Affects telemetry data label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/observability Affects telemetry data kind/bug Something is broken or regressed
Projects
None yet
Development

No branches or pull requests

2 participants