Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional PKCE #783

Closed
liviozanol opened this issue Nov 28, 2022 · 4 comments · Fixed by #789
Closed

Optional PKCE #783

liviozanol opened this issue Nov 28, 2022 · 4 comments · Fixed by #789
Labels
question Further information is requested

Comments

@liviozanol
Copy link

liviozanol commented Nov 28, 2022

As stated on the migration document (https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md) PKCE should be optional even when using code type.

How to config oidc-client-ts to not send code_challenge, code_challenge_method, etc. to the identity server?

Tried to set code_verifier to false but it didn't make any difference.

Thanks in advance.

See also: IdentityModel/oidc-client-js#1360

@pamapa pamapa added the question Further information is requested label Nov 28, 2022
@pamapa
Copy link
Member

pamapa commented Dec 1, 2022

The Authorization Code Grant code path is using PKCE, there is no alternative code path in the library, which can be enabled.

This library focuses on OAuth 2.1, which says:

  • PKCE is required for all OAuth clients using the authorization code flow

That said, we might should improve the migration docu, which seems outdated...

@liviozanol
Copy link
Author

Ok. got it. So maybe it is a good idea to change the migration.md description?

It clearly says "PKCE remains optional"

@pamapa
Copy link
Member

pamapa commented Dec 2, 2022

would be great if you make a merge request and fix that in the documentation!

Moshyfawn pushed a commit to Moshyfawn/oidc-client-ts that referenced this issue Dec 2, 2022
@Moshyfawn
Copy link
Contributor

Is #789 enough to explain the code flow change as per #783 (comment)?

dbfr3qs pushed a commit to dbfr3qs/oidc-client-ts that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants