-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max-width is unsopported #89
Comments
Were you able to resolve the issue as you closed it already? |
No, but the reason for my issues where another. Whenever images get layed out by js, for example in a Slider or Masonry, your script seams to analyse to soon. Not sure, if there would be a solution to this. |
Maybe we could try to trigger a resize event manually here: respimagelint/src/collector/readDimensions.js Lines 134 to 137 in 194f755
|
If it helps, I came across this issue white testing the slider on: https://relaunchlive.granvogl.com/ |
I also experienced this with other sliders from splide.js or slick slider library. During testing, I always used a single slide only because if the slides are changing automatic during the linting process, of course they will get wrong because the image is maybe hidden or even removed from the DOM. |
While using max-width or min-width should both be fine for the sizes attribute, only the approach with min-width validates.
The text was updated successfully, but these errors were encountered: