feat(cli): print any response body from the Pact Broker when authenti…

…cation fails
aushm · Feb 17, 2020 · 116f0d9 · 116f0d9
1 parent 373e4b0
commit 116f0d9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/lib/pact_broker/client/base_client.rb b/lib/pact_broker/client/base_client.rb
@@ -70,7 +70,11 @@ def handle_response response
         elsif response.code == 404
           nil
         elsif response.code == 401
-          raise Error.new("Authentication failed")
+          message = "Authentication failed"
+          if response.body && response.body.size > 0
+            message = message + ": #{response.body}"
+          end
+          raise Error.new(message)
         else
           error_message = nil
           begin

diff --git a/lib/pact_broker/client/matrix.rb b/lib/pact_broker/client/matrix.rb
@@ -20,7 +20,11 @@ def handle_response response
         if response.success?
           yield
         elsif response.code == 401
-          raise Error.new("Authentication failed")
+          message = "Authentication failed"
+          if response.body && response.body.size > 0
+            message = message + ": #{response.body}"
+          end
+          raise Error.new(message)
         elsif response.code == 404
           raise Error.new("Matrix resource not found at #{base_url}/matrix. Please upgrade your Broker to the latest version.")
         else

diff --git a/spec/lib/pact_broker/client/base_client_spec.rb b/spec/lib/pact_broker/client/base_client_spec.rb
@@ -10,15 +10,15 @@ module Client
         let(:password) { 'pact_repo_password'}
         let(:token) { '123456789' }
         let(:client_options) do
-          { 
+          {
             basic_auth: {
               username: username,
               password: password
             },
             token: token
           }
         end
-        
+
         context 'with basic url' do
           it 'sets the base url' do
             base_client = BaseClient.new(base_url: base_url)