Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSVC coverage for remaining suspicious asserts #365

Merged
merged 6 commits into from
Dec 18, 2024
Merged

Add MSVC coverage for remaining suspicious asserts #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
72bc4c4
Add coverage for `is_known_to_be_less_than_one`
chiphogg Dec 18, 2024
eb7e8c2
Try more direct test cases
chiphogg Dec 18, 2024
70bb562
"Fix" it anyway for stylistic consistency
chiphogg Dec 18, 2024
490aef8
Cover `inverse_as`
chiphogg Dec 18, 2024
0faac6e
Fix `inverse_as`
chiphogg Dec 18, 2024
73697c9
Merge branch 'main' into chiphogg/remaining-static-assert-issues#364
chiphogg Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions au/code/au/apply_rational_magnitude_to_integral.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ constexpr T clamp_to_range_of(U x) {
//

template <typename... BPs>
constexpr bool is_known_to_be_less_than_one(Magnitude<BPs...> m) {
constexpr bool is_known_to_be_less_than_one(Magnitude<BPs...>) {
using MagT = Magnitude<BPs...>;
static_assert(is_rational(m), "Magnitude must be rational");
static_assert(is_rational(MagT{}), "Magnitude must be rational");

constexpr auto num_result = get_value_result<std::uintmax_t>(numerator(MagT{}));
static_assert(num_result.outcome == MagRepresentationOutcome::OK,
Expand Down
2 changes: 1 addition & 1 deletion au/code/au/math.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ constexpr auto inverse_in(TargetUnits target_units, Quantity<U, R> q) {
constexpr auto UNITY = make_constant(UnitProductT<>{});

static_assert(
UNITY.in<R>(associated_unit(target_units) * U{}) >= threshold ||
UNITY.in<R>(associated_unit(TargetUnits{}) * U{}) >= threshold ||
std::is_floating_point<R>::value,
"Dangerous inversion risking truncation to 0; must supply explicit Rep if truly desired");

Expand Down
6 changes: 6 additions & 0 deletions single-file-test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ using namespace au;
using ::au::symbols::m;
using ::au::symbols::s;

constexpr auto ns = ::au::nano(s);

// This ad hoc utility is a stand-in for GTEST, which we can't use here.
template <typename ExpectedT, typename ActualT>
bool expect_equal(ExpectedT expected, ActualT actual) {
Expand All @@ -45,6 +47,10 @@ int main(int argc, char **argv) {
{
expect_equal((meters / second)(5) * seconds(6), meters(30)),
expect_equal(SPEED_OF_LIGHT.as<int>(m / s), 299'792'458 * m / s),
expect_equal(detail::is_known_to_be_less_than_one(mag<5>() / mag<7>()), true),
expect_equal(detail::is_known_to_be_less_than_one(mag<7>() / mag<5>()), false),
expect_equal((10 * m).coerce_in(m * mag<5>() / mag<7>()), 14),
expect_equal(inverse_as(ns, 333 / s), 3'003'003 * ns),
},
};
return std::all_of(std::begin(results), std::end(results), [](auto x) { return x; }) ? 0 : 1;
Expand Down
Loading