Add CI jobs for Windows #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this works, I'll need to figure out how to write a test file and compile and run it with MSVC. For now, I'm triggering on every push to every branch for easier testing.
Shot in the dark --- is this why it didn't trigger?
This shouldn't make a difference, but I don't know what will.
I needed to tweak some settings on the repo.
I have no idea how to use powershell
Specifying 3.10.6 replaces 3.10.11, which makes it take way longer.
Guess based on xtensor-stack/xtensor#1152
Maybe it's complaining about using a function parameter as a constant expression?
This reverts commit 872bd5f. We are testing to see whether this causes the build step to fail with similar errors.
The error didn't show up as I expected. Maybe it will on an older MSVC.
The build is broken under the current settings. This should fix it.
Just a guess.
chiphogg
added
release notes: 🐛 lib (bugfix)
|
Current
After landing this PR, it'd be good to add that to the list of required checks. |
|
Since these new jobs are the first in the "best effort" tier, technically they don't have to always be passing. However, I think we want to make, well, our best effort to keep them passing, so I'll make them blocking unless and until something forces us to let them fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job builds a single-file version of the Au library, and runs a
simple test. This test is enough to reproduce the errors in #143:
https://github.com/aurora-opensource/au/actions/runs/5496101666/job/14882361539
It also catches another few compiler errors on other versions of MSVC,
which we fix here. The issue is that function parameters can't be used
in a
constexprcontext in general. These particular parameters aremonovalue types
(https://aurora-opensource.github.io/au/main/reference/detail/monovalue_types/),
so the compiler's being a little pedantic in enforcing this rule, but
this also means that it's easy to fix the error.
With this PR, we go from 0 to 1 in terms of CI jobs for "best effort"
platforms. This gives us a pattern we can use for future new platforms.
Helps #144.