Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: a new module instance is not named by its selected preset and there is no prompt to do so that is automatically displayed. #413

Open
2 tasks done
sahlirc opened this issue Jan 18, 2025 · 6 comments

Comments

@sahlirc
Copy link

sahlirc commented Jan 18, 2025

Code of Conduct

  • I have read this document and I accept the conditions

Search previous report

  • I have searched my issue

Computer's operating system

Windows 7, 8, 10, or 11

What GPU do you have ?

Nvidia

Ansel version

1099

Type of binary

Pre-built packages provided by the Ansel project (.AppImage, .EXE)

What happened?

New instances are automatically named by their occurrence number, and must be renamed explicitly. One has to remember the preset name and then rename the module accordingly after clicking the rename option of the multiple instance actions.
This may be related to issue 222 (december 2023) according to Chantal, where at least the renaming prompt should be proposed from then on.

Does your problem occur with OpenCL enabled ?

Yes

Does your problem occur with OpenCL disabled ?

Yes

Previous Ansel version that use to work

No response

Output of ansel -d all

Backtrace

@aurelienpierre
Copy link
Collaborator

aurelienpierre commented Jan 18, 2025

Why would you want to rename in instance with its preset ? Typically, new instances are used with masks so the name of the instance points to the region of the image that is masked (sky, person, tower, etc.).

Morevover, applying a preset happens after the creation of the instance. Should all presets application lead to an instance renaming ? If not all but only some, how do we decide ? Or let user make the decision each time ?

I think current design is predictable. Niche usages can't all be accounted for in the GUI without creating a forest of options that will actually bury functionnality. You are automatically prompted for a name at the creation of a new instance.

@sahlirc
Copy link
Author

sahlirc commented Jan 18, 2025

This is to have a trace in the pipeline of which preset was used (for instance to sharpen a bird using as mask) with a given preset among several possible.

@aurelienpierre
Copy link
Collaborator

What is your workflow-wise problem here ? What do you ultimately need to achieve that current design prevents you to achieve ? Forget about how you think it should be done, just focus on the end goal.

@sahlirc
Copy link
Author

sahlirc commented Jan 18, 2025

The title of my report was misleading. It is specific to modules with built-in presets be they used only once, or subsequently as new instances. Of course, I achieved my end goal with that particular image. However a sane workflow necessitates for my understanding in the long term (with frequent side by side comparison of the module's effect) that each module used with a specific built-in preset be named accordingly. So of course I can, and will, manually append the built-in preset name to the module.
Don't get me wrong, I do appreciate your effort at simplifying the interface and workflow of Darktable through Ansel, and the tools you provide that help (force) us to understand what we do.

@sahlirc
Copy link
Author

sahlirc commented Jan 19, 2025

I see the problem of renaming the original module by appending the preset name. It should be a property (the preset used with the module) that would be useful to see in the left panel of the development history. One can see it highlighted on hovering the module in the pipeline though.

@sahlirc
Copy link
Author

sahlirc commented Jan 19, 2025

Thank you for having implemented the bold fonts for selected presets in modules in version 1118. This is extremely useful (for me, and my old brain at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants