Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon and perspective breaks when crop is applied prior #308

Open
trougnouf opened this issue Jan 3, 2024 · 5 comments
Open

Horizon and perspective breaks when crop is applied prior #308

trougnouf opened this issue Jan 3, 2024 · 5 comments
Labels
priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability regression

Comments

@trougnouf
Copy link

Description of the bug

To Reproduce

Crop an image

Rotate the image in Horizon and perspective

Expected behavior

Image should remain consistent

Context

Screenshot from 2024-01-03 03-24-26
Screenshot from 2024-01-03 03-23-55
Screenshot from 2024-01-03 03-23-11

I have to disable the perspective module and restart ansel to get the correct image back.

Which commit introduced the error

?

System

  • ansel version : 0.0.0+727~g4d185b439 ( 4d185b4 )
  • OS : Linux 6.6.9-zen
  • Linux - Distro : Arch
  • Memory : 40 GB
  • Graphics card : gfx1032
  • Graphics driver :
  • OpenCL installed : rocm 6.0
  • OpenCL activated : yes, tested without too
  • Xorg : wayland
  • Desktop : gnome
  • GTK+ :
  • gcc : 13.2.1
  • cflags : https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=ansel-git
  • CMAKE_BUILD_TYPE : Release

Additional context

  • Are the steps above reproducible with a fresh edit (i.e. after discarding history)? yes
  • Do you use lua scripts?
    • What lua scripts start automatically? dtMediaWiki
@AlynxZhou
Copy link

I also reproduced this.

cflags : https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=ansel-git

When you are building AUR packages, cflags are actually set in /etc/makepkg.conf.

@lukadh
Copy link
Collaborator

lukadh commented Mar 28, 2024

I ran into the same problem before. There are quite a few issues with the image display at the moment. Most of the time you can work around them using Run > Clear all pipeline caches. In this particular case I also had to collapse the Horizon and perspective module.

@lukadh lukadh added priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability regression labels Mar 28, 2024
@DNedic
Copy link

DNedic commented Apr 3, 2024

I ran into the same issue without using OpenCL at all, I added march=native to my CFLAGS though if that's relevant. Other CFLAGS should be the same as Arch defaults.

@aurelienpierre
Copy link
Collaborator

Still on ? I didn't reproduce.

@lukadh
Copy link
Collaborator

lukadh commented Jan 15, 2025

The image doesn't get garbled anymore, but using Horizon and Perspective after (as in Step1 and Step2, pipeline order is unchanged) Crop will leave the image uncropped. Run > Clear Pipeline Cache brings back the cropped version, now with transformation of Horizon and Perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability regression
Projects
None yet
Development

No branches or pull requests

5 participants