Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%2d in querystring converted to space instead of plus #52

Open
tiljanssen opened this issue May 15, 2019 · 7 comments
Open

%2d in querystring converted to space instead of plus #52

tiljanssen opened this issue May 15, 2019 · 7 comments

Comments

@tiljanssen
Copy link

I'm submitting a bug report

  • Library Version:
    1.3.2

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    9.4.0

  • NPM Version:
    5.6.0

  • JSPM OR Webpack AND Version
    webpack 4.29.0

  • Browser:
    Chrome

  • Language:
    TypeScript

Current behavior:
Since 1.3.2 %2B (+) in the querystring is replaced by space in the params object passed to the Activate() function.
Probably related to 957532d

Expected/desired behavior:

  • What is the expected behavior?

  • What is the motivation / use case for changing the behavior?

@bigopon
Copy link
Member

bigopon commented May 15, 2019

@tiljanssen You are correct, sorry for this, please use 1.3.1 for now.
@EisenbergEffect @davismj I'll revert that commit

@davismj
Copy link
Member

davismj commented May 16, 2019

@bigopon related, right? aurelia/path#30

@bigopon
Copy link
Member

bigopon commented May 17, 2019

@davismj yes. We can close that with the revert pr too

@Xenope
Copy link

Xenope commented May 29, 2019

+1, I have issues since this commit 957532d too. The decodeURIComponent added really messes up the parameters while navigating.

@bigopon
Copy link
Member

bigopon commented May 29, 2019

This has been fixed, waiting for a released from @EisenbergEffect

@EisenbergEffect
Copy link
Contributor

EisenbergEffect commented May 29, 2019

@bigopon It appears that CI is broken. That's why this never released. The changes made on develop were not merged to master and thus there appeared to be no release ready. @fkleuver @bigopon What is the best path for us in this case? I can manually merge develop into master and then cut a release. Should we take a look at what's going on here to make things break?

@fkleuver
Copy link
Member

@bigopon @EisenbergEffect The reason CI fails is because there is no version bump in the prepare-release script. So it tries to publish to the local verdaccio proxy with the same version, and errors out right there. That's the only missing piece.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants