Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login popup window? #59

Open
HIRANO-Satoshi opened this issue Jul 25, 2018 · 4 comments
Open

Login popup window? #59

HIRANO-Satoshi opened this issue Jul 25, 2018 · 4 comments

Comments

@HIRANO-Satoshi
Copy link

Hi,

As login requires transition to a login page where is apart from Aurelia, downloading the bundle occurs twice, before and after login. That was mentioned in #24 and seems stucking.

But the oidc-client-js should work with a popup login window as its sample does, right? Is there any reason why you don't use it? Difficult to use?

https://github.com/IdentityModel/oidc-client-js/blob/dev/samples/VanillaJS/public/user-manager-sample-popup-signin.html

@arnederuwe
Copy link
Collaborator

It's definitely possible, but this plugin was designed to plug into the Aurelia router, creating the OIDC redirect routes for you and handling them.
You would need another system for pop-ups, as the redirect routes would not hit the Aurelia app itself but the pop-up.
@shaunluttin are you open for a pull request on this? I would like to give it a shot

@HIRANO-Satoshi
Copy link
Author

Thanks.

Since I am using another library, I would like to close this issue.

@arnederuwe
Copy link
Collaborator

Since it's not fixed, I would rather leave it open as a feature request :)

@HIRANO-Satoshi
Copy link
Author

all right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants